From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Alex Williamson <alex.williamson@redhat.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
KVM list <kvm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] vfio: platform: Add generic DT reset controller support
Date: Thu, 12 Apr 2018 08:54:23 +0200 [thread overview]
Message-ID: <20180412065422.zsm4ztlet4zgober@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXq5gTrYBGnP8EfL4s_c+=JA6vXgrmgs3Wa_+8cS3jYNA@mail.gmail.com>
Hi Geert,
On Wed, Apr 11, 2018 at 10:39:19AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Apr 11, 2018 at 10:22 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Apr 10, 2018 at 05:53:47PM +0200, Geert Uytterhoeven wrote:
...
> >> @@ -217,6 +236,9 @@ static int vfio_platform_call_reset(struct vfio_platform_device *vdev,
> >> } else if (vdev->of_reset) {
> >> dev_info(vdev->device, "reset\n");
> >> return vdev->of_reset(vdev);
> >> + } else if (vdev->reset_control) {
> >> + dev_info(vdev->device, "reset\n");
> >
> > Would it be useful to differentiate between the above two informational
> > messages?
>
> Probably not, there's also no differentiation with the message for the
> ACPI case above (out of visible context).
Thanks, I agree that it seems fine to leave things as you have them above.
prev parent reply other threads:[~2018-04-12 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:53 [PATCH v2 0/2] vfio: platform: Improve reset support Geert Uytterhoeven
2018-04-10 15:53 ` [PATCH v2 1/2] vfio: platform: Fix reset module leak in error path Geert Uytterhoeven
2018-04-11 8:09 ` Simon Horman
2018-04-10 15:53 ` [PATCH v2 2/2] vfio: platform: Add generic DT reset controller support Geert Uytterhoeven
2018-04-11 8:22 ` Philipp Zabel
2018-04-11 8:43 ` Geert Uytterhoeven
2018-04-11 8:22 ` Simon Horman
2018-04-11 8:39 ` Geert Uytterhoeven
2018-04-12 6:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412065422.zsm4ztlet4zgober@verge.net.au \
--to=horms@verge.net.au \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).