From: Moritz Fischer <mdf@kernel.org>
To: gregkh@linux-foundation.org
Cc: linux-fpga.vger@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, atull@kernel.org,
robh+dt@kernel.org, Moritz Fischer <mdf@kernel.org>
Subject: [PATCH 3/3] fpga: fpga-region: comment on fpga_region_program_fpga locking
Date: Mon, 16 Apr 2018 20:43:37 -0700 [thread overview]
Message-ID: <20180417034337.8855-4-mdf@kernel.org> (raw)
In-Reply-To: <20180417034337.8855-1-mdf@kernel.org>
From: Alan Tull <atull@kernel.org>
Add a comment to the header of fpga_region_program_fpga()
regarding locking of the bridges.
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/fpga/fpga-region.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index edab2a2e03ef..cb0603e07ff8 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -95,6 +95,11 @@ static void fpga_region_put(struct fpga_region *region)
* fpga_region_program_fpga - program FPGA
* @region: FPGA region
* Program an FPGA using fpga image info (region->info).
+ * If the region has a get_bridges function, the exclusive reference for the
+ * bridges will be held if programming succeeds. This is intended to prevent
+ * reprogramming the region until the caller considers it safe to do so.
+ * The caller will need to call fpga_bridges_put() before attempting to
+ * reprogram the region.
* Return 0 for success or negative error code.
*/
int fpga_region_program_fpga(struct fpga_region *region)
--
2.17.0
prev parent reply other threads:[~2018-04-17 3:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 3:43 [PATCH 0/3] FPGA Manager Patches for 4.18 Moritz Fischer
2018-04-17 3:43 ` [PATCH 1/3] dt: bindings: fpga: add lattice machxo2 slave spi binding description Moritz Fischer
2018-04-17 3:43 ` [PATCH 2/3] fpga: lattice machxo2: Add Lattice MachXO2 support Moritz Fischer
2018-04-17 3:43 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417034337.8855-4-mdf@kernel.org \
--to=mdf@kernel.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linux-foundation.org \
--cc=linux-fpga.vger@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).