From: James Hogan <jhogan@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Paul Cercueil <paul@crapouillou.net>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Mathieu Malaterre <malat@debian.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Harvey Hunt <harvey.hunt@imgtec.com>
Subject: Re: [PATCH] MIPS: dts: avoid unneeded built-in.a creation in vendor DTS directories
Date: Tue, 17 Apr 2018 22:37:36 +0100 [thread overview]
Message-ID: <20180417213736.GC21386@saruman> (raw)
In-Reply-To: <1523893290-7958-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
On Tue, Apr 17, 2018 at 12:41:30AM +0900, Masahiro Yamada wrote:
> arch/mips/boot/dts/Makefile collects objects from sub-directories
> into built-in.a only when CONFIG_BUILTIN_DTB is enabled. Reflect
> it also to the sub-directory Makefiles. This suppresses unneeded
> built-in.a creation in arch/mips/boot/dts/*/ directories.
>
> While I am here, I replaced $(patsubst %.dtb, %.dtb.o, $(dtb-y))
> with $(addsuffix .o, $(dtb-y)) to simplify the code a little bit.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/mips/boot/dts/brcm/Makefile | 2 +-
> arch/mips/boot/dts/cavium-octeon/Makefile | 2 +-
> arch/mips/boot/dts/ingenic/Makefile | 2 +-
> arch/mips/boot/dts/lantiq/Makefile | 2 +-
> arch/mips/boot/dts/mscc/Makefile | 2 +-
> arch/mips/boot/dts/mti/Makefile | 2 +-
> arch/mips/boot/dts/netlogic/Makefile | 2 +-
> arch/mips/boot/dts/pic32/Makefile | 2 +-
> arch/mips/boot/dts/ralink/Makefile | 2 +-
> arch/mips/boot/dts/xilfpga/Makefile | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/mips/boot/dts/brcm/Makefile b/arch/mips/boot/dts/brcm/Makefile
> index d8787c9..d85f446 100644
> --- a/arch/mips/boot/dts/brcm/Makefile
> +++ b/arch/mips/boot/dts/brcm/Makefile
> @@ -34,4 +34,4 @@ dtb-$(CONFIG_DT_NONE) += \
> bcm97425svmb.dtb \
> bcm97435svmb.dtb
>
> -obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
> +obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
I like this. I had also spotted the .o files being unnecessarily
generated when building the dtbs target with bmips and CONFIG_DT_NONE=y.
I'll apply for 4.18.
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-17 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 15:41 [PATCH] MIPS: dts: avoid unneeded built-in.a creation in vendor DTS directories Masahiro Yamada
2018-04-17 21:37 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417213736.GC21386@saruman \
--to=jhogan@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=harvey.hunt@imgtec.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).