Re: [PATCH v6 01/11] ARM: sunxi: smp: Move assembly code into a file

Chen-Yu Tsai
2018-04-17T03:12:41Z

On Tue, Apr 17, 2018 at 5:50 AM, Mylène Josserand
<mylene.josserand@bootlin.com> wrote:
> Move the assembly code for cluster cache enabling and resuming
> into an assembly file instead of having it directly in C code.
>
> Remove the CFLAGS because we are using the ARM directive "arch"
> instead.
>
> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> ---
> arch/arm/mach-sunxi/Makefile | 4 +--
> arch/arm/mach-sunxi/headsmp.S | 80 +++++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-sunxi/mc_smp.c | 82 +++----------------------------------------
> 3 files changed, 85 insertions(+), 81 deletions(-)
> create mode 100644 arch/arm/mach-sunxi/headsmp.S

I'm still not convinced about this whole "move ASM to separate
file" thing, especially now that you aren't actually adding any
sunxi-specific ASM code beyond a simple function call.

Could you drop this for now?

ChenYu