From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source Date: Thu, 19 Apr 2018 22:24:42 +0800 Message-ID: <20180419142441.GW25429@dragon> References: <1521426645-19246-1-git-send-email-Anson.Huang@nxp.com> <1521426645-19246-2-git-send-email-Anson.Huang@nxp.com> <20180417142203.GM25429@dragon> <152410785516.46528.12432838242068784117@swboyd.mtv.corp.google.com> <20180419140236.GU25429@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180419140236.GU25429@dragon> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Anson Huang , mark.rutland@arm.com, devicetree@vger.kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shengjiu.wang@nxp.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, Apr 19, 2018 at 10:02:37PM +0800, Shawn Guo wrote: > On Wed, Apr 18, 2018 at 08:17:35PM -0700, Stephen Boyd wrote: > > Quoting Shawn Guo (2018-04-17 07:22:05) > > > On Mon, Mar 19, 2018 at 10:30:45AM +0800, Anson Huang wrote: > > > > On i.MX6SX SabreAuto board, there is external 24MHz clock > > > > source for analog clock2, add this clock source to clock tree. > > > > > > > > Signed-off-by: Anson Huang > > > > --- > > > > changes since V1: > > > > remove unnecessary clocks container. > > > > > > I understand this is suggested by Fabio, but I'm afraid that it's not > > > going to work with imx_obtain_fixed_clock() call, which is coded to > > > look for clocks under /clocks node. > > > > > > > Should patch #1 be dropped from clk tree? > > No. Patch #1 is good. Sorry, Stephen. I just had a closer look at the driver code, and I think it can be done in a better way. So please drop patch #1 for now. Shawn