From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Date: Fri, 20 Apr 2018 16:44:45 -0600 Message-ID: <20180420224445.GB18235@codeaurora.org> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <152165924074.91116.13025068669916027026@swboyd.mtv.corp.google.com> <493c1f5d-df99-ca68-0f90-a7937a696f5d@codeaurora.org> <152411734938.46528.9676451637772936597@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: David Collins Cc: Stephen Boyd , broonie@kernel.org, lgirdwood@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org List-Id: devicetree@vger.kernel.org On Fri, Apr 20 2018 at 13:07 -0600, David Collins wrote: >On 04/18/2018 10:55 PM, Stephen Boyd wrote: >> Quoting David Collins (2018-03-22 18:30:06) >>> On 03/21/2018 12:07 PM, Stephen Boyd wrote: >>>> Quoting David Collins (2018-03-16 18:09:10) >>>>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig >>>>> index 097f617..e0ecd0a 100644 >>>>> + ret = cmd_db_ready(); >>>>> + if (ret < 0) { >>>>> + if (ret != -EPROBE_DEFER) >>>>> + dev_err(dev, "Command DB not available, ret=%d\n", ret); >>>>> + return ret; >>>>> + } >>>> >>>> We should just make rpmh parent device call cmd_db_ready() so that these >>>> devices aren't even populated until then and so that cmd_db_ready() is >>>> only in one place. Lina? >>> >>> Let's see if Lina has qualms about this plan. >> >> Sounds like you're ok with it. > >Sure, I'll remove this check if Lina agrees to add it in the rpmh driver. > We want to make the RSC nodes child of Command DB? That way we probe the controllers only if the command DB is ready? I could do that. Just so you know, there is are no strict directives to use Command DB. If a driver knows the information it needs to pass to the accelerator, it may choose to skip command DB completely. Thanks, Lina