devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Veenstra <davidjulianveenstra@gmail.com>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, robh+dt@kernel.org, pmeerw@pmeerw.net,
	knaack.h@gmx.de, daniel.baluta@nxp.com
Subject: Re: [PATCH v2 09/13] staging: iio: ad2s1200: Add documentation for device tree binding
Date: Sat, 21 Apr 2018 18:03:23 +0100	[thread overview]
Message-ID: <20180421180323.502d94de@archlinux> (raw)
In-Reply-To: <2b0596e9dd109a8ea949c38d9e9abb0e38e8bc5e.1524247563.git.davidjulianveenstra@gmail.com>

On Fri, 20 Apr 2018 21:30:54 +0200
David Veenstra <davidjulianveenstra@gmail.com> wrote:

> Add documentation for the added device tree bindings.
> 
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
Straight forward, but please introduce it directly in
bindings/iio/resolver rather than moving it.

The binding doesn't require a driver to be outside of staging
so there would be no harm in doing this directly.

Jonathan

> ---
> Changes in v2:
>   - Introduced in this version.
> 
>  .../bindings/staging/iio/resolver/ad2s1200.txt           | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/staging/iio/resolver/ad2s1200.txt
> 
> diff --git a/Documentation/devicetree/bindings/staging/iio/resolver/ad2s1200.txt b/Documentation/devicetree/bindings/staging/iio/resolver/ad2s1200.txt
> new file mode 100644
> index 000000000000..85c009987878
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/staging/iio/resolver/ad2s1200.txt
> @@ -0,0 +1,16 @@
> +Analog Devices AD2S1200 Resolver-to-Digital Converter
> +
> +Required properties:
> + - compatible : should be "adi,ad2s1200"
> + - reg : the SPI chip select number of the device
> + - sample-gpios : The GPIO pin connected to the SAMPLE line of the AD2S1200
> + - rdvel-gpios : The GPIO pin connected to the RDVEL line of the AD2S1200
> +
> +Example:
> +
> +	resolver {
> +		compatible = "adi,ad2s1200";
> +		reg = <4>;
> +		sample-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> +		rdvel-gpios = <&gpio 6 GPIO_ACTIVE_HIGH>;
> +	};

  reply	other threads:[~2018-04-21 17:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 19:28 [PATCH v2 00/13] staging: iio: ad2s1200: Driver clean up David Veenstra
2018-04-20 19:28 ` [PATCH v2 01/13] staging: iio: ad2s1200: Remove unneeded include David Veenstra
2018-04-21 16:45   ` Jonathan Cameron
2018-04-20 19:28 ` [PATCH v2 02/13] staging: iio: ad2s1200: Sort includes alphabetically David Veenstra
2018-04-21 16:46   ` Jonathan Cameron
2018-04-20 19:29 ` [PATCH v2 03/13] staging: iio: ad2s1200: Reverse Christmas tree ordering David Veenstra
2018-04-21 16:46   ` Jonathan Cameron
2018-04-20 19:29 ` [PATCH v2 04/13] staging: iio: ad2s1200: Add blank lines David Veenstra
2018-04-21 16:47   ` Jonathan Cameron
2018-04-20 19:30 ` [PATCH v2 05/13] staging: iio: ad2s1200: Add kernel docs to driver state David Veenstra
2018-04-21 16:49   ` Jonathan Cameron
2018-04-22 14:26     ` David Julian Veenstra
2018-04-20 19:30 ` [PATCH v2 06/13] staging: iio: ad2s1200: Introduce variable for repeated value David Veenstra
2018-04-21 16:50   ` Jonathan Cameron
2018-04-22 14:29     ` David Julian Veenstra
2018-04-20 19:30 ` [PATCH v2 07/13] staging: iio: ad2s1200: Improve readability with be16_to_cpup David Veenstra
2018-04-21 16:55   ` Jonathan Cameron
2018-04-22 14:31     ` David Julian Veenstra
2018-04-20 19:30 ` [PATCH v2 08/13] staging: iio: ad2s1200: Replace legacy gpio API with modern API David Veenstra
2018-04-21 16:58   ` Jonathan Cameron
2018-04-22 14:32     ` David Julian Veenstra
2018-04-20 19:30 ` [PATCH v2 09/13] staging: iio: ad2s1200: Add documentation for device tree binding David Veenstra
2018-04-21 17:03   ` Jonathan Cameron [this message]
2018-04-20 19:31 ` [PATCH v2 10/13] staging: iio: ad2s1200: Add scaling factor for angular velocity channel David Veenstra
2018-04-21 17:07   ` Jonathan Cameron
2018-04-22 14:37     ` David Julian Veenstra
2018-04-20 19:31 ` [PATCH v2 11/13] staging: iio: Documentation: Add missing sysfs docs for angle channel David Veenstra
2018-04-21 17:08   ` Jonathan Cameron
2018-04-22 14:41     ` David Julian Veenstra
2018-04-20 19:31 ` [PATCH v2 12/13] staging: iio: ad2s1200: Add scaling factor " David Veenstra
2018-04-21 17:10   ` Jonathan Cameron
2018-04-20 19:32 ` [PATCH v2 13/13] staging: iio: ad2s1200: Move driver out of staging David Veenstra
2018-04-21 17:11   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180421180323.502d94de@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@nxp.com \
    --cc=davidjulianveenstra@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).