[PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Niklas Söderlund]

From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

The datasheet have been expanded with more registers and the DT files
have been updated with the new size. This change updates the example so
writing new DT files can use the enchanted driver which uses the new
registers.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 .../devicetree/bindings/thermal/rcar-gen3-thermal.txt       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
index fdf5caa6229b4fff..39e7d4e61a63c038 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
@@ -27,9 +27,9 @@ Example:
 
 	tsc: thermal@e6198000 {
 		compatible = "renesas,r8a7795-thermal";
-		reg = <0 0xe6198000 0 0x68>,
-		      <0 0xe61a0000 0 0x5c>,
-		      <0 0xe61a8000 0 0x5c>;
+		reg = <0 0xe6198000 0 0x100>,
+		      <0 0xe61a0000 0 0x100>,
+		      <0 0xe61a8000 0 0x100>;
 		interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.17.0

Re: [PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Geert Uytterhoeven]

On Tue, Apr 17, 2018 at 10:49 PM, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> The datasheet have been expanded with more registers and the DT files
> have been updated with the new size. This change updates the example so
> writing new DT files can use the enchanted driver which uses the new
> registers.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Sergei Shtylyov]

Hello!

On 4/17/2018 11:49 PM, Niklas Söderlund wrote:

> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> The datasheet have been expanded with more registers and the DT files
> have been updated with the new size. This change updates the example so
> writing new DT files can use the enchanted driver which uses the new

    Enhanced, maybe? Or was there indeed some magic in the air? :-)

> registers.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
[...]

MBR, Sergei

Re: [PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Simon Horman]

On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas Söderlund wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> The datasheet have been expanded with more registers and the DT files

Nit: "datasheets have" or "datasheet has"

> have been updated with the new size. This change updates the example so
> writing new DT files can use the enchanted driver which uses the new
> registers.

As Sergei mentioned, maybe enhanced rather than enchanted :)

> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

The documentation change itself looks fine to me:

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  .../devicetree/bindings/thermal/rcar-gen3-thermal.txt       | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> index fdf5caa6229b4fff..39e7d4e61a63c038 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> @@ -27,9 +27,9 @@ Example:
>  
>  	tsc: thermal@e6198000 {
>  		compatible = "renesas,r8a7795-thermal";
> -		reg = <0 0xe6198000 0 0x68>,
> -		      <0 0xe61a0000 0 0x5c>,
> -		      <0 0xe61a8000 0 0x5c>;
> +		reg = <0 0xe6198000 0 0x100>,
> +		      <0 0xe61a0000 0 0x100>,
> +		      <0 0xe61a8000 0 0x100>;
>  		interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
>  			     <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
>  			     <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.17.0
> 

Re: [PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Rob Herring]

On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas S�derlund wrote:
> From: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> 
> The datasheet have been expanded with more registers and the DT files
> have been updated with the new size. This change updates the example so
> writing new DT files can use the enchanted driver which uses the new
> registers.
> 
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  .../devicetree/bindings/thermal/rcar-gen3-thermal.txt       | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied with Simon's comments addressed.

Rob

Re: [PATCH] dt-bindings: thermal: rcar-gen3-thermal: update register size in example

[Niklas Söderlund]

Hi Rob,

On 2018-04-24 09:28:41 -0500, Rob Herring wrote:
> On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas S�derlund wrote:
> > From: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> > 
> > The datasheet have been expanded with more registers and the DT files
> > have been updated with the new size. This change updates the example so
> > writing new DT files can use the enchanted driver which uses the new
> > registers.
> > 
> > Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> >  .../devicetree/bindings/thermal/rcar-gen3-thermal.txt       | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Applied with Simon's comments addressed.

Thanks for addressing Simon's comments while applying. I had planed to 
repost the thermal patches I got comments for later today so this is one 
less thing for me to do :-)

> 
> Rob

-- 
Regards,
Niklas S�derlund