devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Christophe Roullier <christophe.roullier@st.com>
Cc: mark.rutland@arm.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@st.com, peppe.cavallaro@st.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH  1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.
Date: Tue, 24 Apr 2018 17:39:53 +0200	[thread overview]
Message-ID: <20180424153953.GB2360@lunn.ch> (raw)
In-Reply-To: <1524582120-4451-2-git-send-email-christophe.roullier@st.com>

On Tue, Apr 24, 2018 at 05:01:53PM +0200, Christophe Roullier wrote:

> +	case PHY_INTERFACE_MODE_RGMII:
> +		val = SYSCFG_PMCR_ETH_SEL_RGMII;
> +		if (dwmac->int_phyclk)
> +			val |= SYSCFG_PMCR_ETH_CLK_SEL;
> +		pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n");
> +		break;

Hi Christophe

What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID
and PHY_INTERFACE_MODE_RGMII_TXID.

    Andrew

  reply	other threads:[~2018-04-24 15:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:01 [PATCH 0/8] net: ethernet: stmmac: add support for stm32mp1 Christophe Roullier
2018-04-24 15:01 ` [PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c Christophe Roullier
2018-04-24 15:39   ` Andrew Lunn [this message]
2018-04-25  7:12     ` Christophe ROULLIER
2018-04-25 12:40       ` Andrew Lunn
2018-04-24 15:01 ` [PATCH 2/8] dt-bindings: stm32-dwmac: add support of MPU families Christophe Roullier
2018-05-01 13:58   ` Rob Herring
2018-05-02  8:15     ` Christophe ROULLIER
2018-04-24 15:01 ` [PATCH 3/8] ARM: dts: stm32: add ethernet pins to stm32mp157c Christophe Roullier
2018-04-25 15:09   ` Rob Herring
2018-04-25 16:22     ` Alexandre Torgue
2018-04-24 15:01 ` [PATCH 4/8] ARM: dts: stm32: Add syscfg on stm32mp1 Christophe Roullier
2018-04-24 15:01 ` [PATCH 5/8] ARM: dts: stm32: Add ethernet dwmac " Christophe Roullier
2018-04-24 15:01 ` [PATCH 6/8] net: stmmac: add dwmac-4.20a compatible Christophe Roullier
2018-04-24 15:01 ` [PATCH 7/8] ARM: dts: stm32: add support of ethernet on stm32mp157c-ev1 Christophe Roullier
2018-04-24 15:02 ` [PATCH 8/8] dt-bindings: stm32: add compatible for syscon Christophe Roullier
2018-05-01 14:01   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424153953.GB2360@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.torgue@st.com \
    --cc=christophe.roullier@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).