From: Andrew Lunn <andrew@lunn.ch>
To: Rob Herring <robh@kernel.org>
Cc: "Måns Andersson" <mans.andersson@nibe.se>,
"Mark Rutland" <mark.rutland@arm.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: TLK10X initial driver submission
Date: Tue, 24 Apr 2018 19:52:34 +0200 [thread overview]
Message-ID: <20180424175234.GC2360@lunn.ch> (raw)
In-Reply-To: <20180424163455.vmftcg5xbj6svtcu@rob-hp-laptop>
> > +Required properties:
> > + - reg - The ID number for the phy, usually a small integer
>
> Isn't this the MDIO bus address?
Hi Rob
Yes. This text has been take direct from the generic PHY binding.
> This should have a compatible string too.
Please see Documentation/devicetree/bindings/net/phy.txt
compatible strings are optional. We know what device it is from its ID
registers, which are in a well known location.
Andrew
next prev parent reply other threads:[~2018-04-24 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 8:28 [PATCH] net: phy: TLK10X initial driver submission Måns Andersson
2018-04-19 12:09 ` Andrew Lunn
2018-04-20 6:58 ` Måns Andersson
2018-04-19 12:24 ` Miguel Ojeda
2018-04-20 7:07 ` Måns Andersson
2018-04-24 16:34 ` Rob Herring
2018-04-24 17:52 ` Andrew Lunn [this message]
2018-04-24 16:52 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424175234.GC2360@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mans.andersson@nibe.se \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).