From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] iio: potentiostat: lmp91000: add LMP91002 support
Date: Sat, 28 Apr 2018 17:04:05 +0100 [thread overview]
Message-ID: <20180428170405.105c8e9a@archlinux> (raw)
In-Reply-To: <CAJCx=gkUUo70O7c14orRr=tUSeQDNRq1PRX1mSQL6u3YP1G+kQ@mail.gmail.com>
On Thu, 26 Apr 2018 19:17:09 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> On Thu, Apr 26, 2018 at 7:15 PM, Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
> > LMP91002 is register compatible so add devicetree and i2c client ids
> >
> > Cc: device-tree@vger.kernel.org
>
> *sigh* should be devicetree@vger.kernel.org ... adding correct CC
>
> > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> > ---
> > Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt | 7 ++++---
> > drivers/iio/potentiostat/lmp91000.c | 2 ++
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > index b9b621e94cd7..d51639f0ebbf 100644
> > --- a/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > +++ b/Documentation/devicetree/bindings/iio/potentiostat/lmp91000.txt
> > @@ -1,10 +1,11 @@
> > -* Texas Instruments LMP91000 potentiostat
> > +* Texas Instruments LMP91000 series of potentiostats
> >
> > -http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> > +LMP91000: http://www.ti.com/lit/ds/symlink/lmp91000.pdf
> > +LMP91002: http://www.ti.com/lit/ds/symlink/lmp91002.pdf
> >
> > Required properties:
> >
> > - - compatible: should be "ti,lmp91000"
> > + - compatible: should be "ti,lmp91000" or "ti,lmp91002"
Please put each entry on a new line. Reduces churn going forward.
Thanks,
Jonathan
> > - reg: the I2C address of the device
> > - io-channels: the phandle of the iio provider
> >
> > diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> > index 85714055cc74..90e895adf997 100644
> > --- a/drivers/iio/potentiostat/lmp91000.c
> > +++ b/drivers/iio/potentiostat/lmp91000.c
> > @@ -411,12 +411,14 @@ static int lmp91000_remove(struct i2c_client *client)
> >
> > static const struct of_device_id lmp91000_of_match[] = {
> > { .compatible = "ti,lmp91000", },
> > + { .compatible = "ti,lmp91002", },
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, lmp91000_of_match);
> >
> > static const struct i2c_device_id lmp91000_id[] = {
> > { "lmp91000", 0 },
> > + { "lmp91002", 0 },
> > {}
> > };
> > MODULE_DEVICE_TABLE(i2c, lmp91000_id);
> > --
> > 2.14.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-04-28 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180427021505.29526-1-matt.ranostay@konsulko.com>
2018-04-27 2:17 ` [PATCH] iio: potentiostat: lmp91000: add LMP91002 support Matt Ranostay
2018-04-28 16:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428170405.105c8e9a@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).