From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v3 4/5] soc/tegra: pmc: Use of_clk_get_parent_count() instead of open coding Date: Mon, 30 Apr 2018 15:44:20 +0200 Message-ID: <20180430134420.GE11457@mai> References: <1524063005-1716-1-git-send-email-geert+renesas@glider.be> <1524063005-1716-5-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1524063005-1716-5-git-send-email-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Rob Herring , Frank Rowand , Thomas Gleixner , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Heiko Stuebner , Thierry Reding , Jonathan Hunter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Apr 18, 2018 at 04:50:04PM +0200, Geert Uytterhoeven wrote: > As of_clk_get_parent_count() returns zero on failure, while > of_count_phandle_with_args() might return a negative error code, this > also fixes the issue of possibly using a very big number in the > allocation below. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Jon Hunter > --- > This depends on "[PATCH v3 1/5] clk: Extract OF clock helpers in > ". > > v3: > - Add Acked-by, > > v2: > - of_clk_get_parent_count() was moved to . > --- Reviewed-by: Daniel Lezcano Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog