From: Rob Herring <robh@kernel.org>
To: Brandon Maier <brandon.maier@gmail.com>
Cc: mark.rutland@arm.com, michal.simek@xilinx.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: net: gmii2rgmii: Clarify proper usage
Date: Tue, 1 May 2018 08:16:48 -0500 [thread overview]
Message-ID: <20180501131648.GA4135@rob-hp-laptop> (raw)
In-Reply-To: <CADwxmTn3fS50oAvqEj947RC5Hnq0q6666_CGvWU7KMmtOc=fvw@mail.gmail.com>
On Fri, Apr 27, 2018 at 11:20:01PM +0000, Brandon Maier wrote:
> On Fri, Apr 27, 2018 at 4:13 PM Rob Herring <robh@kernel.org> wrote:
> ...
> > > + gem0: ethernet@e000b000 {
> > > + compatible = "cdns,zynq-gem", "cdns,gem";
> > > + phy-handle = <&phy>;
>
> > The phy here and...
> ...
> > > + gmiitorgmii: gmiitorgmii@8 {
> > > + compatible = "xlnx,gmii-to-rgmii-1.0";
> > > + reg = <8>;
> > > + phy-handle = <&phy>;
>
> > ...here doesn't look right.
>
>
> I don't see what you're referring to, they appear to match the
> phy/phy-handle formats in Documentation/devicetree/bindings/net/phy.txt and
> ethernet.txt. It's a bit odd that the label is just "phy", when most phy
> labels are "phy0" etc., is that what should be changed?
You don't need both properties. If the ethernet driver needs the phy,
then it can decend into the child nodes to find it.
Rob
next prev parent reply other threads:[~2018-05-01 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 4:01 [PATCH 1/2] dt-bindings: net: gmii2rgmii: Fix typos Brandon Maier
2018-04-22 4:01 ` [PATCH 2/2] dt-bindings: net: gmii2rgmii: Clarify proper usage Brandon Maier
2018-04-27 21:13 ` Rob Herring
2018-04-27 23:20 ` Brandon Maier
2018-05-01 13:16 ` Rob Herring [this message]
2018-05-01 15:08 ` Brandon Maier
2018-04-27 21:11 ` [PATCH 1/2] dt-bindings: net: gmii2rgmii: Fix typos Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501131648.GA4135@rob-hp-laptop \
--to=robh@kernel.org \
--cc=brandon.maier@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox