From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add fixed 26MHz clock as fck for twl
Date: Tue, 1 May 2018 08:39:56 -0700 [thread overview]
Message-ID: <20180501153956.GG98604@atomide.com> (raw)
In-Reply-To: <CAHCN7x+Ow7B4kTmd+4PkDd=azn-qKMYmEyjqfb8GkXA7Y7pEPA@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [180501 15:32]:
> On Thu, Apr 5, 2018 at 6:52 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> > The board uses 26MHz oscillator for the twl4030 HFCLK.
> > This way we will not depend on the bootloader to configure the
> > CFG_BOOT:HFCLK_FREQ
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > ---
> > Hi,
> >
> > there might be other boards (all omap3 boards with twl4030?) which uses the same
> > setup, but I only have schematics for beagle-xm.
> >
>
> I know I am late coming into this, but we have twl4030_omap3.dtsi for
> the items common to omap3. Can we put the clock reference in that
> file?
>
> It seems like it would be cleaner than having a dozen boards or so
> boards having the exact same copy of the same stuff. SHould something
> change in the future, I would think it would make
> maintenance easier too. Just my two cents.
Well we don't know if it's a 26MiHz clock on all of them. Some use
38MiHz at least. Sure the board can override it but let's first
fix up each board then later on add the common node.
Regards,
Tony
prev parent reply other threads:[~2018-05-01 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 11:52 [PATCH] ARM: dts: omap3-beagle-xm: Add fixed 26MHz clock as fck for twl Peter Ujfalusi
2018-04-05 13:15 ` Peter Ujfalusi
2018-04-06 7:00 ` Peter Ujfalusi
2018-05-01 15:18 ` Tony Lindgren
2018-05-01 15:30 ` Adam Ford
2018-05-01 15:39 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501153956.GG98604@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).