From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver Date: Fri, 4 May 2018 10:12:14 +0200 Message-ID: <20180504081214.3luailyresuq5x4z@flea> References: <20180419154124.17512-1-paul.kocialkowski@bootlin.com> <20180419154536.17846-4-paul.kocialkowski@bootlin.com> <1524153860.3416.9.camel@pengutronix.de> <5fa80b1e88ad2a215f51ea3a2b9b62274fa9b1ec.camel@bootlin.com> <20180427030436.3ptrb2ldhtnssipj@rob-hp-laptop> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fjsv7zqvnkrt3jk5" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Paul Kocialkowski Cc: Rob Herring , Tomasz Figa , Philipp Zabel , Linux Media Mailing List , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "list-Y9sIeH5OGRo@public.gmane.org:IOMMU DRIVERS , Joerg Roedel ," , Linux Kernel Mailing List , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Mauro Carvalho Chehab , Mark Rutland , wens-jdAy2FN1RRM@public.gmane.org, Pawel Osciak , Marek Szyprowski , Kyungmin Park , Hans Verkuil , Sakari Ailus , Arnd Bergmann , Alexandre Courbot List-Id: devicetree@vger.kernel.org --fjsv7zqvnkrt3jk5 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, May 04, 2018 at 09:56:20AM +0200, Paul Kocialkowski wrote: > > > I agree that the term VPU is more commonly associated with video > > > decoding, while video engine could mean a number of things. > > > > > > The reason I went with "video-engine" here (while still presenting > > > the > > > driver as a VPU driver) is that Video Engine is the term used in > > > Allwinner's litterature. Other nodes in Allwinner device-trees > > > generally > > > stick to these terms (for instance, we have "display-engine" nodes). > > > This also makes it easier to find the matching parts in the > > > documentation. > > > > 'video-codec' is what is defined in the DT spec. > > Is that an actively-enforced guideline or a suggestion? I'd like to keep > video-engine just to stick with the technical documentation wording and > my personal taste is also to prefer vpu over video-codec (in terms of > clarity/straightforwardness) as a second choice. > > Still, if the choice isn't up to me, we can go with video-codec (or > vpu). The unit-name is supposed to reflect the class of the device, and nothing else. If there's already a pre-existing class name defined for these kind of devices, then there's no point in choosing something else. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --fjsv7zqvnkrt3jk5--