From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [RFC PATCH] ARM: dts: imx: replace underscore with hyphen in aliases name Date: Fri, 4 May 2018 16:15:08 +0800 Message-ID: <20180504081506.GZ3443@dragon> References: <1525399128-11587-1-git-send-email-shawnguo@kernel.org> <20180504085248.532c8a47@karo-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20180504085248.532c8a47@karo-electronics.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: devicetree@vger.kernel.org, Gary Bisson , Rob Herring , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, May 04, 2018 at 08:52:48AM +0200, Lothar Wa=DFmann wrote: > Hi, > = > On Fri, 4 May 2018 09:58:48 +0800 Shawn Guo wrote: > > It replaces underscore with hyphen in aliases name to fix DTC > > alias_paths warning below, which is seen with various i.MX board dts > > files when W=3D1 switch is on. > > = > > Warning (alias_paths): /aliases: aliases property name must include on= ly lowercase and '-' > > = > > Cc: Lothar Wa=DFmann > > Cc: Gary Bisson > > Signed-off-by: Shawn Guo > > --- > > Hi Lothar, Gary, > > = > > Per my search on kernel code, this change will not break anything on > > kernel support. But I'm not really sure about the case of bootloaders > > running on the boards. That's why I'm sending it as RFC. > > = > > We really want i.MX to be the first-class citizen in the community. > > After a few cycles efforts on cleaning up DTC warnings, this alias_paths > > warning is the last one we see with i.MX dts files. We really want to > > get rid of it and make i.MX dts be DTC warning free. > > = > > So please comment whether we can merge this patch. > > = > This breaks our U-Boot which searches for the alias names with '_'. > But I think it's not worth keeping the old names alive, since the > problem can easily be fixed by adding the old alias name to the FDT > on affected boards from within U-Boot, if necessary. > = > Alternatively we could add a: > reg_can_xcvr =3D "reg-can-xcvr"; > [...] > so that the respective aliases can be resolved using both names for a > while. Appreciate it. > = > So: > Acked-By: Lothar Wa=DFmann Thanks, Lothar. Shawn