From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails Date: Fri, 4 May 2018 10:06:53 +0200 Message-ID: <20180504100653.6ee70802@bbrezillon> References: <20180503164009.14395-1-boris.brezillon@bootlin.com> <20180503164009.14395-7-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , David Airlie , dri-devel , Thierry Reding , Kumar Gala List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKT24gVGh1LCAzIE1heSAyMDE4IDEyOjEyOjM5IC0wNTAwClJvYiBIZXJyaW5nIDxy b2JoK2R0QGtlcm5lbC5vcmc+IHdyb3RlOgoKPiBPbiBUaHUsIE1heSAzLCAyMDE4IGF0IDExOjQw IEFNLCBCb3JpcyBCcmV6aWxsb24KPiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPiB3cm90 ZToKPiA+IFRoZSBkZXZpY2UgbWlnaHQgYmUgZGVzY3JpYmVkIGluIHRoZSBkZXZpY2UgdHJlZSBi dXQgbm90IGNvbm5lY3RlZCB0bwo+ID4gdGhlIEkyQyBidXMuIFVwZGF0ZSB0aGUgc3RhdHVzIHBy b3BlcnR5IHNvIHRoYXQgdGhlIERSTSBwYW5lbCBsb2dpYwo+ID4gcmV0dXJucyAtRU5PREVWIHdo ZW4gc29tZW9uZSB0cmllcyB0byBnZXQgdGhlIHBhbmVsIGF0dGFjaGVkIHRvIHRoaXMKPiA+IERU IG5vZGUuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6 aWxsb25AYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+ICAuLi4vZ3B1L2RybS9wYW5lbC9wYW5lbC1y YXNwYmVycnlwaS10b3VjaHNjcmVlbi5jICB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysKPiA+ ICAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91Y2hzY3JlZW4uYyBiL2Ry aXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNjcmVlbi5jCj4gPiBp bmRleCAyYzljOTcyMjczNGYuLmI4ZmNiMWFjZWY3NSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNjcmVlbi5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91Y2hzY3JlZW4uYwo+ID4g QEAgLTM1OCw2ICszNTgsMzkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fcGFuZWxfZnVuY3Mg cnBpX3RvdWNoc2NyZWVuX2Z1bmNzID0gewo+ID4gICAgICAgICAuZ2V0X21vZGVzID0gcnBpX3Rv dWNoc2NyZWVuX2dldF9tb2RlcywKPiA+ICB9Owo+ID4KPiA+ICtzdGF0aWMgdm9pZCBycGlfdG91 Y2hzY3JlZW5fc2V0X3N0YXR1c19mYWlsKHN0cnVjdCBpMmNfY2xpZW50ICppMmMpCj4gPiArewo+ ID4gKyAgICAgICBzdHJ1Y3QgcHJvcGVydHkgKm5ld3Byb3A7Cj4gPiArCj4gPiArICAgICAgIG5l d3Byb3AgPSBremFsbG9jKHNpemVvZigqbmV3cHJvcCksIEdGUF9LRVJORUwpOwo+ID4gKyAgICAg ICBpZiAoIW5ld3Byb3ApCj4gPiArICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gKwo+ID4gKyAg ICAgICBuZXdwcm9wLT5uYW1lID0ga3N0cmR1cCgic3RhdHVzIiwgR0ZQX0tFUk5FTCk7Cj4gPiAr ICAgICAgIGlmICghbmV3cHJvcC0+bmFtZSkKPiA+ICsgICAgICAgICAgICAgICBnb3RvIGVycjsK PiA+ICsKPiA+ICsgICAgICAgbmV3cHJvcC0+dmFsdWUgPSBrc3RyZHVwKCJmYWlsIiwgR0ZQX0tF Uk5FTCk7Cj4gPiArICAgICAgIGlmICghbmV3cHJvcC0+dmFsdWUpCj4gPiArICAgICAgICAgICAg ICAgZ290byBlcnI7Cj4gPiArCj4gPiArICAgICAgIG5ld3Byb3AtPmxlbmd0aCA9IHNpemVvZigi ZmFpbCIpOwo+ID4gKwo+ID4gKyAgICAgICBpZiAob2ZfdXBkYXRlX3Byb3BlcnR5KGkyYy0+ZGV2 Lm9mX25vZGUsIG5ld3Byb3ApKQo+ID4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyOwo+ID4gKyAg Cj4gCj4gQXMgSSBtZW50aW9uZWQgb24gaXJjLCBjYW4geW91IG1ha2UgdGhpcyBhIGNvbW1vbiBE VCBmdW5jdGlvbi4KClllcCwgd2lsbCBtb3ZlIHRoYXQgdG8gZHJpdmVycy9vZi9iYXNlLmMgYW5k IG1ha2UgaXQgZ2VuZXJpYy4KCj4gCj4gSSdtIG5vdCBzdXJlIGlmIGl0IG1hdHRlcnMgdGhhdCB3 ZSBzZXQgc3RhdHVzIHRvIGZhaWwgdnMuIGRpc2FibGVkLiBJCj4gc29tZXdoYXQgcHJlZmVyIHRo ZSBsYXR0ZXIgYXMgd2UgYWxyZWFkeSBoYXZlIG90aGVyIGNhc2VzIGFuZCBJJ2QKPiByYXRoZXIg dGhlIGFwaSBub3QgcGFzcyBhIHN0cmluZyBpbi4gSSBjYW4ndCB0aGluayBvZiBhbnkgcmVhc29u IHRvCj4gZGlzdGluZ3Vpc2ggdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiBmYWlsIGFuZCBkaXNhYmxl ZC4KCldlbGwsIEkganVzdCByZWFkIHRoZSBlUEFQUiBkb2MgcG9pbnRlZCBieSBUaGllcnJ5IFsx XSAoc2VjdGlvbiAyLjMuNCksCmFuZCAiZmFpbCIgc2VlbWVkIGxpa2UgYSBnb29kIG1hdGNoIGZv ciB3aGF0IHdlIGFyZSB0cnlpbmcgdG8gZXhwcmVzcwpoZXJlOiAid2UgZmFpbGVkIHRvIGNvbW11 bmljYXRlIHdpdGggdGhlIGRldmljZSBpbiB0aGUgcHJvYmUgZnVuY3Rpb24KYW5kIHdhbnQgdG8g bWFyayBpdCB1bnVzYWJsZSIsIHdoaWNoIGlzIGEgYml0IGRpZmZlcmVudCBmcm9tICJ0aGUKZGV2 aWNlIHdhcyBleHBsaWNpdGx5IGRpc2FibGVkIGJ5IHRoZSB1c2VyIi4KCkFueXdheSwgaWYgeW91 IHRoaW5rICJkaXNhYmxlZCIgaXMgbW9yZSBhcHByb3ByaWF0ZSwgSSdsbCB1c2UgdGhhdC4KCj4g Cj4gPiArICAgICAgIC8qIFdlIGludGVudGlvbmFsbHkgbGVhayB0aGUgbWVtb3J5IHdlIGFsbG9j YXRlIGhlcmUsIGJlY2F1c2UgdGhlIG5ldwo+ID4gKyAgICAgICAgKiBPRiBwcm9wZXJ0eSBtaWdo dCBsaXZlIGxvbmdlciB0aGFuIHRoZSB1bmRlcmx5aW5nIGRldiwgc28gbm8gd2F5Cj4gPiArICAg ICAgICAqIHdlIGNhbiB1c2UgZGV2bV9remFsbG9jKCkgaGVyZS4KPiA+ICsgICAgICAgICovCj4g PiArICAgICAgIHJldHVybjsKPiA+ICsKPiA+ICtlcnI6Cj4gPiArICAgICAgIGtmcmVlKG5ld3By b3AtPnZhbHVlKTsKPiA+ICsgICAgICAga2ZyZWUobmV3cHJvcC0+bmFtZSk7Cj4gPiArICAgICAg IGtmcmVlKG5ld3Byb3ApOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IHJwaV90b3VjaHNj cmVlbl9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqaTJjLAo+ID4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgKmlkKQo+ID4gIHsKPiA+ IEBAIC0zODIsNiArNDE1LDcgQEAgc3RhdGljIGludCBycGlfdG91Y2hzY3JlZW5fcHJvYmUoc3Ry dWN0IGkyY19jbGllbnQgKmkyYywKPiA+Cj4gPiAgICAgICAgIHZlciA9IHJwaV90b3VjaHNjcmVl bl9pMmNfcmVhZCh0cywgUkVHX0lEKTsKPiA+ICAgICAgICAgaWYgKHZlciA8IDApIHsKPiA+ICsg ICAgICAgICAgICAgICBycGlfdG91Y2hzY3JlZW5fc2V0X3N0YXR1c19mYWlsKGkyYyk7ICAKPiAK PiBJJ3ZlIHRob3VnaHQgc29tZSBtb3JlIGFib3V0IHRoaXMgYW5kIEkgc3RpbGwgdGhpbmsgdGhp cyBzaG91bGQgYmUKPiBoYW5kbGVkIGluIHRoZSBkcml2ZXIgY29yZSBvciBpMmMgY29yZS4KPiAK PiBUaGUgcmVhc29uIGlzIHNpbXBsZS4gSSB0aGluayB0aGUgc3RhdGUgb2YgdGhlIHN5c3RlbSBz aG91bGQgYmUgdGhlCj4gc2FtZSBhZnRlciB0aGlzIGFzIGlmIHlvdSBib290ZWQgd2l0aCAnc3Rh dHVzID0gImRpc2FibGVkIicgZm9yIHRoaXMKPiBub2RlLiBBbmQgdGhhdCBtZWFucyB0aGUgZGV2 aWNlIHNob3VsZCBiZSByZW1vdmVkIGNvbXBsZXRlbHkgYmVjYXVzZQo+IHdlIGRvbid0IGNyZWF0 ZSBzdHJ1Y3QgZGV2aWNlJ3MgZm9yIGRpc2FibGVkIG5vZGVzLgoKVGhhdCB3YXMgbXkgZmVlbGlu ZyB0byB3aGVuIGZpcnN0IGRpc2N1c3NpbmcgdGhlIGlzc3VlIHdpdGggRGFuaWVsIGFuZApUaGll cnJ5IG9uIElSQywgYnV0IGFmdGVyIGRpZ2dpbmcgYSBiaXQgaW4gdGhlIGNvZGUgSSdtIG5vIGxv bmdlciBzdXJlCnRoaXMgaXMgYSBnb29kIGlkZWEuIEF0IGxlYXN0LCBJIGRvbid0IHRoaW5rIGJh c2luZyB0aGUgZGVjaXNpb24gdG8KZGlzYWJsZSB0aGUgZGV2aWNlIChvciBtYXJrIGl0IHVudXNh YmxlKSBiYXNlZCBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mCnRoZSBwcm9iZSBmdW5jdGlvbiBpcyBh IGdvb2QgaWRlYS4gV2hhdCBJIGNhbiBkbyBpczoKCjEvIHByb3ZpZGUgYSBmdW5jdGlvbiB0byBj aGFuZ2UgdGhlIHN0YXR1cyBwcm9wIGluIG9mLmgKMi8gbGV0IGVhY2ggZHJpdmVyIGNhbGwgdGhp cyBmdW5jdGlvbiBpZiB0aGV5IHdhbnQgdG8KMy8gbGV0IHRoZSBJMkMgY29yZSB0ZXN0IHRoZSBz dGF0dXMgcHJvcCBhZ2FpbiBhZnRlciB0aGUgcHJvYmUgZnVuY3Rpb24KICAgaGFzIHJldHVybmVk IGFuIGVycm9yIHRvIGRldGVybWluZSB3aGV0aGVyIHRoZSBkZXZpY2UgKEkgbWVhbiBzdHJ1Y3QK ICAgaTJjX2NsaWVudC9kZXZpY2Ugb2JqZWN0KSBzaG91bGQgYmUgcmVtb3ZlZAoKV291bGQgdGhh dCB3b3JrIGZvciB5b3U/CgpSZWdhcmRzLAoKQm9yaXMKClsxXWh0dHBzOi8vZWxpbnV4Lm9yZy9p bWFnZXMvYy9jZi9Qb3dlcl9lUEFQUl9BUFBST1ZFRF92MS4xLnBkZgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK