From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-imx@nxp.com, kernel@pengutronix.de,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: imx: drop 'clocks' container for board level clocks
Date: Fri, 4 May 2018 10:18:10 +0200 [thread overview]
Message-ID: <20180504101810.065b01f6@karo-electronics.de> (raw)
In-Reply-To: <1525395446-1953-5-git-send-email-shawnguo@kernel.org>
Hi,
On Fri, 4 May 2018 08:57:26 +0800 Shawn Guo wrote:
> For soc level of clocks which are input to Clock Control Module, clock
> driver expects them to be under 'clocks' container node. But for board
> level clocks, this container is not really necessary. Let's drop it and
> use an unique name for fixed rate clock, so that 'reg' property can be
> saved as well.
>
For imx28-tx28.dts and imx53-tx53.dtsi:
Acked-By: Lothar Waßmann <LW@KARO-electronics.de>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> arch/arm/boot/dts/imx28-tx28.dts | 13 ++++---------
> arch/arm/boot/dts/imx53-tx53.dtsi | 11 +++++------
> arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 15 ++++++---------
> arch/arm/boot/dts/imx6q-bx50v3.dtsi | 11 ++++-------
> 4 files changed, 19 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 687186358c18..e4f19f9be6d0 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -140,15 +140,10 @@
> regulator-boot-on;
> };
>
> - clocks {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - mclk: clock@0 {
> - compatible = "fixed-clock";
> - reg = <0>;
> - #clock-cells = <0>;
> - clock-frequency = <26000000>;
> - };
> + mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <26000000>;
> };
>
> sound {
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 77f2ce9f1e41..5dd3dd3a2fd0 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -67,13 +67,12 @@
> ckih1 {
> clock-frequency = <0>;
> };
> + };
>
> - mclk: clock@0 {
> - compatible = "fixed-clock";
> - reg = <0>;
> - #clock-cells = <0>;
> - clock-frequency = <26000000>;
> - };
> + mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <26000000>;
> };
>
> gpio-keys {
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index ea184d108491..3dee3af1a4c1 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -72,15 +72,12 @@
> stdout-path = "serial0:115200n8";
> };
>
> - clocks {
> - /* Fixed crystal dedicated to mcp251x */
> - clk16m: clk@1 {
> - compatible = "fixed-clock";
> - reg = <1>;
> - #clock-cells = <0>;
> - clock-frequency = <16000000>;
> - clock-output-names = "clk16m";
> - };
> + /* Fixed crystal dedicated to mcp251x */
> + clk16m: clock-16m {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <16000000>;
> + clock-output-names = "clk16m";
> };
>
> gpio-keys {
> diff --git a/arch/arm/boot/dts/imx6q-bx50v3.dtsi b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> index d0e7dab4d72b..d3cba09be0cb 100644
> --- a/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> +++ b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> @@ -43,13 +43,10 @@
> #include "imx6q-ba16.dtsi"
>
> / {
> - clocks {
> - mclk: clock@0 {
> - compatible = "fixed-clock";
> - reg = <0>;
> - #clock-cells = <0>;
> - clock-frequency = <22000000>;
> - };
> + mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <22000000>;
> };
>
> gpio-poweroff {
Lothar Waßmann
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-05-04 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 0:57 [PATCH 0/4] Fix avoid_unnecessary_addr_size DTC warning with 'clocks' node Shawn Guo
2018-05-04 0:57 ` [PATCH 1/4] ARM: dts: imx: drop unnecessary #address-cells/#size-cells Shawn Guo
2018-05-04 0:57 ` [PATCH 2/4] ARM: dts: imx1: move clk32 clock into soc dtsi Shawn Guo
2018-05-04 0:57 ` [PATCH 3/4] ARM: dts: imx27: use lable to override osc26m clock setting Shawn Guo
2018-05-04 15:34 ` Fabio Estevam
2018-05-07 1:39 ` Shawn Guo
2018-05-04 0:57 ` [PATCH 4/4] ARM: dts: imx: drop 'clocks' container for board level clocks Shawn Guo
2018-05-04 8:18 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504101810.065b01f6@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).