From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Date: Fri, 4 May 2018 13:49:56 -0700 Message-ID: <20180504134956.36dc72a253d03e94a517a867@linux-foundation.org> References: <20180305102524.5905-1-o.rempel@pengutronix.de> <20180305102524.5905-4-o.rempel@pengutronix.de> <20180504185052.bjhfkvpgrblc7tfc@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180504185052.bjhfkvpgrblc7tfc@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Oleksij Rempel Cc: kernel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Leonard Crestez , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Fabio Estevam , Russell King , Shawn Guo , Mark Brown , "Rafael J . Wysocki" List-Id: devicetree@vger.kernel.org On Fri, 4 May 2018 20:50:52 +0200 Oleksij Rempel wrote: > Hallo Andrew, > I need your ACK or NACK for this patch. > > This function is used to configure external PMIC to interpret > signal which will be triggered by pm_power_off as power off. > Since same signal can be used for stand by, I linked PMIC configuration > with pm_power_off_prepare to avoid possible conflicts. > > ... > > > --- a/kernel/reboot.c > > +++ b/kernel/reboot.c > > @@ -49,6 +49,7 @@ int reboot_force; > > */ > > > > void (*pm_power_off_prepare)(void); > > +EXPORT_SYMBOL(pm_power_off_prepare); > > OK by me, but it's more of a Rafael thing.