From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails Date: Fri, 4 May 2018 14:17:49 +0200 Message-ID: <20180504141749.03ef85fe@bbrezillon> References: <20180503164009.14395-1-boris.brezillon@bootlin.com> <20180503164009.14395-7-boris.brezillon@bootlin.com> <20180504100653.6ee70802@bbrezillon> <20180504094748.GD13459@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180504094748.GD13459@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , David Airlie , dri-devel , Rob Herring , Kumar Gala List-Id: devicetree@vger.kernel.org T24gRnJpLCA0IE1heSAyMDE4IDExOjQ3OjQ4ICswMjAwClRoaWVycnkgUmVkaW5nIDx0aGllcnJ5 LnJlZGluZ0BnbWFpbC5jb20+IHdyb3RlOgoKPiBPbiBGcmksIE1heSAwNCwgMjAxOCBhdCAxMDow Njo1M0FNICswMjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiBIaSBSb2IsCj4gPiAKPiA+ IE9uIFRodSwgMyBNYXkgMjAxOCAxMjoxMjozOSAtMDUwMAo+ID4gUm9iIEhlcnJpbmcgPHJvYmgr ZHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiAgIAo+ID4gPiBPbiBUaHUsIE1heSAzLCAyMDE4IGF0 IDExOjQwIEFNLCBCb3JpcyBCcmV6aWxsb24KPiA+ID4gPGJvcmlzLmJyZXppbGxvbkBib290bGlu LmNvbT4gd3JvdGU6ICAKPiA+ID4gPiBUaGUgZGV2aWNlIG1pZ2h0IGJlIGRlc2NyaWJlZCBpbiB0 aGUgZGV2aWNlIHRyZWUgYnV0IG5vdCBjb25uZWN0ZWQgdG8KPiA+ID4gPiB0aGUgSTJDIGJ1cy4g VXBkYXRlIHRoZSBzdGF0dXMgcHJvcGVydHkgc28gdGhhdCB0aGUgRFJNIHBhbmVsIGxvZ2ljCj4g PiA+ID4gcmV0dXJucyAtRU5PREVWIHdoZW4gc29tZW9uZSB0cmllcyB0byBnZXQgdGhlIHBhbmVs IGF0dGFjaGVkIHRvIHRoaXMKPiA+ID4gPiBEVCBub2RlLgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVk LW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Cj4g PiA+ID4gLS0tCj4gPiA+ID4gIC4uLi9ncHUvZHJtL3BhbmVsL3BhbmVsLXJhc3BiZXJyeXBpLXRv dWNoc2NyZWVuLmMgIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKQo+ID4gPiA+Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNjcmVlbi5jIGIvZHJp dmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXJhc3BiZXJyeXBpLXRvdWNoc2NyZWVuLmMKPiA+ID4g PiBpbmRleCAyYzljOTcyMjczNGYuLmI4ZmNiMWFjZWY3NSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcmFzcGJlcnJ5cGktdG91Y2hzY3JlZW4uYwo+ID4g PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1yYXNwYmVycnlwaS10b3VjaHNj cmVlbi5jCj4gPiA+ID4gQEAgLTM1OCw2ICszNTgsMzkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBk cm1fcGFuZWxfZnVuY3MgcnBpX3RvdWNoc2NyZWVuX2Z1bmNzID0gewo+ID4gPiA+ICAgICAgICAg LmdldF9tb2RlcyA9IHJwaV90b3VjaHNjcmVlbl9nZXRfbW9kZXMsCj4gPiA+ID4gIH07Cj4gPiA+ ID4KPiA+ID4gPiArc3RhdGljIHZvaWQgcnBpX3RvdWNoc2NyZWVuX3NldF9zdGF0dXNfZmFpbChz dHJ1Y3QgaTJjX2NsaWVudCAqaTJjKQo+ID4gPiA+ICt7Cj4gPiA+ID4gKyAgICAgICBzdHJ1Y3Qg cHJvcGVydHkgKm5ld3Byb3A7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgbmV3cHJvcCA9IGt6 YWxsb2Moc2l6ZW9mKCpuZXdwcm9wKSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ID4gKyAgICAgICBpZiAo IW5ld3Byb3ApCj4gPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybjsKPiA+ID4gPiArCj4gPiA+ ID4gKyAgICAgICBuZXdwcm9wLT5uYW1lID0ga3N0cmR1cCgic3RhdHVzIiwgR0ZQX0tFUk5FTCk7 Cj4gPiA+ID4gKyAgICAgICBpZiAoIW5ld3Byb3AtPm5hbWUpCj4gPiA+ID4gKyAgICAgICAgICAg ICAgIGdvdG8gZXJyOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIG5ld3Byb3AtPnZhbHVlID0g a3N0cmR1cCgiZmFpbCIsIEdGUF9LRVJORUwpOwo+ID4gPiA+ICsgICAgICAgaWYgKCFuZXdwcm9w LT52YWx1ZSkKPiA+ID4gPiArICAgICAgICAgICAgICAgZ290byBlcnI7Cj4gPiA+ID4gKwo+ID4g PiA+ICsgICAgICAgbmV3cHJvcC0+bGVuZ3RoID0gc2l6ZW9mKCJmYWlsIik7Cj4gPiA+ID4gKwo+ ID4gPiA+ICsgICAgICAgaWYgKG9mX3VwZGF0ZV9wcm9wZXJ0eShpMmMtPmRldi5vZl9ub2RlLCBu ZXdwcm9wKSkKPiA+ID4gPiArICAgICAgICAgICAgICAgZ290byBlcnI7Cj4gPiA+ID4gKyAgICAK PiA+ID4gCj4gPiA+IEFzIEkgbWVudGlvbmVkIG9uIGlyYywgY2FuIHlvdSBtYWtlIHRoaXMgYSBj b21tb24gRFQgZnVuY3Rpb24uICAKPiA+IAo+ID4gWWVwLCB3aWxsIG1vdmUgdGhhdCB0byBkcml2 ZXJzL29mL2Jhc2UuYyBhbmQgbWFrZSBpdCBnZW5lcmljLgo+ID4gICAKPiA+ID4gCj4gPiA+IEkn bSBub3Qgc3VyZSBpZiBpdCBtYXR0ZXJzIHRoYXQgd2Ugc2V0IHN0YXR1cyB0byBmYWlsIHZzLiBk aXNhYmxlZC4gSQo+ID4gPiBzb21ld2hhdCBwcmVmZXIgdGhlIGxhdHRlciBhcyB3ZSBhbHJlYWR5 IGhhdmUgb3RoZXIgY2FzZXMgYW5kIEknZAo+ID4gPiByYXRoZXIgdGhlIGFwaSBub3QgcGFzcyBh IHN0cmluZyBpbi4gSSBjYW4ndCB0aGluayBvZiBhbnkgcmVhc29uIHRvCj4gPiA+IGRpc3Rpbmd1 aXNoIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gZmFpbCBhbmQgZGlzYWJsZWQuICAKPiA+IAo+ID4g V2VsbCwgSSBqdXN0IHJlYWQgdGhlIGVQQVBSIGRvYyBwb2ludGVkIGJ5IFRoaWVycnkgWzFdIChz ZWN0aW9uIDIuMy40KSwKPiA+IGFuZCAiZmFpbCIgc2VlbWVkIGxpa2UgYSBnb29kIG1hdGNoIGZv ciB3aGF0IHdlIGFyZSB0cnlpbmcgdG8gZXhwcmVzcwo+ID4gaGVyZTogIndlIGZhaWxlZCB0byBj b21tdW5pY2F0ZSB3aXRoIHRoZSBkZXZpY2UgaW4gdGhlIHByb2JlIGZ1bmN0aW9uCj4gPiBhbmQg d2FudCB0byBtYXJrIGl0IHVudXNhYmxlIiwgd2hpY2ggaXMgYSBiaXQgZGlmZmVyZW50IGZyb20g InRoZQo+ID4gZGV2aWNlIHdhcyBleHBsaWNpdGx5IGRpc2FibGVkIGJ5IHRoZSB1c2VyIi4KPiA+ IAo+ID4gQW55d2F5LCBpZiB5b3UgdGhpbmsgImRpc2FibGVkIiBpcyBtb3JlIGFwcHJvcHJpYXRl LCBJJ2xsIHVzZSB0aGF0Lgo+ID4gICAKPiA+ID4gICAKPiA+ID4gPiArICAgICAgIC8qIFdlIGlu dGVudGlvbmFsbHkgbGVhayB0aGUgbWVtb3J5IHdlIGFsbG9jYXRlIGhlcmUsIGJlY2F1c2UgdGhl IG5ldwo+ID4gPiA+ICsgICAgICAgICogT0YgcHJvcGVydHkgbWlnaHQgbGl2ZSBsb25nZXIgdGhh biB0aGUgdW5kZXJseWluZyBkZXYsIHNvIG5vIHdheQo+ID4gPiA+ICsgICAgICAgICogd2UgY2Fu IHVzZSBkZXZtX2t6YWxsb2MoKSBoZXJlLgo+ID4gPiA+ICsgICAgICAgICovCj4gPiA+ID4gKyAg ICAgICByZXR1cm47Cj4gPiA+ID4gKwo+ID4gPiA+ICtlcnI6Cj4gPiA+ID4gKyAgICAgICBrZnJl ZShuZXdwcm9wLT52YWx1ZSk7Cj4gPiA+ID4gKyAgICAgICBrZnJlZShuZXdwcm9wLT5uYW1lKTsK PiA+ID4gPiArICAgICAgIGtmcmVlKG5ld3Byb3ApOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4g PiA+ICBzdGF0aWMgaW50IHJwaV90b3VjaHNjcmVlbl9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAq aTJjLAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVj dCBpMmNfZGV2aWNlX2lkICppZCkKPiA+ID4gPiAgewo+ID4gPiA+IEBAIC0zODIsNiArNDE1LDcg QEAgc3RhdGljIGludCBycGlfdG91Y2hzY3JlZW5fcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmky YywKPiA+ID4gPgo+ID4gPiA+ICAgICAgICAgdmVyID0gcnBpX3RvdWNoc2NyZWVuX2kyY19yZWFk KHRzLCBSRUdfSUQpOwo+ID4gPiA+ICAgICAgICAgaWYgKHZlciA8IDApIHsKPiA+ID4gPiArICAg ICAgICAgICAgICAgcnBpX3RvdWNoc2NyZWVuX3NldF9zdGF0dXNfZmFpbChpMmMpOyAgICAKPiA+ ID4gCj4gPiA+IEkndmUgdGhvdWdodCBzb21lIG1vcmUgYWJvdXQgdGhpcyBhbmQgSSBzdGlsbCB0 aGluayB0aGlzIHNob3VsZCBiZQo+ID4gPiBoYW5kbGVkIGluIHRoZSBkcml2ZXIgY29yZSBvciBp MmMgY29yZS4KPiA+ID4gCj4gPiA+IFRoZSByZWFzb24gaXMgc2ltcGxlLiBJIHRoaW5rIHRoZSBz dGF0ZSBvZiB0aGUgc3lzdGVtIHNob3VsZCBiZSB0aGUKPiA+ID4gc2FtZSBhZnRlciB0aGlzIGFz IGlmIHlvdSBib290ZWQgd2l0aCAnc3RhdHVzID0gImRpc2FibGVkIicgZm9yIHRoaXMKPiA+ID4g bm9kZS4gQW5kIHRoYXQgbWVhbnMgdGhlIGRldmljZSBzaG91bGQgYmUgcmVtb3ZlZCBjb21wbGV0 ZWx5IGJlY2F1c2UKPiA+ID4gd2UgZG9uJ3QgY3JlYXRlIHN0cnVjdCBkZXZpY2UncyBmb3IgZGlz YWJsZWQgbm9kZXMuICAKPiA+IAo+ID4gVGhhdCB3YXMgbXkgZmVlbGluZyB0byB3aGVuIGZpcnN0 IGRpc2N1c3NpbmcgdGhlIGlzc3VlIHdpdGggRGFuaWVsIGFuZAo+ID4gVGhpZXJyeSBvbiBJUkMs IGJ1dCBhZnRlciBkaWdnaW5nIGEgYml0IGluIHRoZSBjb2RlIEknbSBubyBsb25nZXIgc3VyZQo+ ID4gdGhpcyBpcyBhIGdvb2QgaWRlYS4gQXQgbGVhc3QsIEkgZG9uJ3QgdGhpbmsgYmFzaW5nIHRo ZSBkZWNpc2lvbiB0bwo+ID4gZGlzYWJsZSB0aGUgZGV2aWNlIChvciBtYXJrIGl0IHVudXNhYmxl KSBiYXNlZCBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mCj4gPiB0aGUgcHJvYmUgZnVuY3Rpb24gaXMg YSBnb29kIGlkZWEuICAKPiAKPiBJJ20gbm90IHNvIHN1cmUgYWJvdXQgdGhhdC4gLUVOT0RFViBz ZWVtcyBsaWtlIGEgdmVyeSBzdWl0YWJsZSBlcnJvcgo+IGNvZGUgdG8gYmFzZSB0aGF0IGRlY2lz aW9uIG9uLiBBIHJhbmRvbSBzYW1wbGluZyBvZiBhIGhhbmRmdWwgb2YgZHJpdmVycwo+IGNvbmZp cm1zIHRoYXQgdGhpcyBpcyBwcmltYXJpbHkgdXNlZCB0byByZXBvcnQgc2l0dWF0aW9ucyB3aGVy ZSBpdCBpcwo+IGltcG9zc2libGUgZm9yIHRoZSBkZXZpY2UgdG8gZXZlciBiZSBwcm9iZWQgc3Vj Y2Vzc2Z1bGx5LCBzbyBtaWdodCBhcwo+IHdlbGwganVzdCByZW1vdmUgaXQuCgpJdCdzIG5vdCB0 aGF0IGVhc3kuIEl0IGhhcyB0byBiZSBkb25lIGZyb20gdGhlIEkyQyBjb3JlIHNpbmNlIGl0J3Mg dGhlCm9ubHkgb25lIHdobyBjYW4gY2FsbCBkZXZpY2VfdW5yZWdpc3RlcigpIGFuZCBjbGVhbnVw IHRoZSBvdGhlciBiaXRzCmFzc29jaWF0ZWQgd2l0aCBhbiBJMkMgZGV2aWNlIChzZWUgaTJjX3Vu cmVnaXN0ZXJfZGV2aWNlKCkpLiBOb3csIHRoZQppMmNfZHJpdmVyLT5wcm9iZSgpIGZ1bmN0aW9u IGlzIGNhbGxlZCBmcm9tIGEgY29udGV4dCB3aGVyZSBJJ20gYWxtb3N0CnN1cmUgZGV2aWNlX3Vu cmVnaXN0ZXIoKSBjYW4ndCBiZSBjYWxsZWQgc2luY2Ugd2UgbWlnaHQgc3RpbGwgYmUgaW4gdGhl CmRldmljZV9yZWdpc3RlcigpIHBhdGguIFRoZSBzb2x1dGlvbiB3b3VsZCBiZSB0byBxdWV1ZSB0 aGUKdW5yZWdpc3RyYXRpb24gd29yayB0byBhIHdvcmtxdWV1ZSwgYnV0IEknbSBub3QgZXZlbiBz dXJlIHRoaXMgaXMgc2FmZQp0byBkbyB0aGF0LiBXaGF0IGlmIHRoZSBJMkMgYWRhcHRlciBleHBv c2luZyB0aGUgZGV2aWNlIGlzIHJlbW92ZWQgaW4KdGhlIG1lYW50aW1lPyBPZiBjb3Vyc2UsIGFs bCBvZiB0aGlzIGNhbiBiZSBhZGRyZXNzZWQsIEknbSBqdXN0CndvbmRlcmluZyBpZiBpdCdzIHJl YWxseSB3b3J0aCB0aGUgdHJvdWJsZSAod2UncmUgbGlrZWx5IHRvIGludHJvZHVjZQpuZXcgcmFj ZXMgb3Igb3RoZXIga2luZCBvZiBidWdzIHdoaWxlIGRvaW5nIHRoYXQpLCBlc3BlY2lhbGx5IHNp bmNlCnBsYWNpbmcgdGhlIGRldmljZSBpbiBhICJmYWlsIiBzdGF0ZSBhbmQgc3RpbGwga2VlcGlu ZyBpdCBhcm91bmQgd291bGQKc29sdmUgdGhlIHByb2JsZW0gd2l0aG91dCByZXF1aXJpbmcgYWxs IHRoZSBleHRyYSBjbGVhbnVwIHdlJ3JlIHRhbGtpbmcKYWJvdXQgaGVyZS4KCj4gCj4gQXQgdGhl IHZlcnkgbGVhc3QgSSB0aGluayBpdCBpcyB3b3J0aCBwcm9wb3NpbmcgdGhlIHBhdGNoIGFuZCBs ZXQgR3JlZwo+IGFuZCBvdGhlcnMgd2VpZ2ggaW4uCgpXZWxsLCBpZiBpdCB3YXMgYW4gZWFzeSB0 aGluZyB0byBkbywgSSBndWVzcyBJIHdvdWxkIGhhdmUgZ29uZSBmb3IgdGhpcwphcHByb2FjaCBm cm9tIHRoZSBiZWdpbm5pbmcsIGJ1dCBJIGZlYXIgZG9pbmcgdGhhdCB3aWxsIGJlIG11Y2ggbW9y ZQpjb21wbGljYXRlZCB0aGFuIHdlIHRoaW5rIGl0IGlzIChtYXliZSBJJ20gd3JvbmcpLgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK