From: Rui Miguel Silva <rui.silva@linaro.org>
To: mchehab@kernel.org, sakari.ailus@linux.intel.com,
hverkuil@xs4all.nl, Rob Herring <robh+dt@kernel.org>
Cc: linux-media@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, Ryan Harkin <ryan.harkin@linaro.org>,
Rui Miguel Silva <rui.silva@linaro.org>
Subject: [PATCH 2/4] media: ov2680: dt: rename gpio to reset and fix polarity
Date: Mon, 7 May 2018 16:56:53 +0100 [thread overview]
Message-ID: <20180507155655.1555-3-rui.silva@linaro.org> (raw)
In-Reply-To: <20180507155655.1555-1-rui.silva@linaro.org>
Since the GPIO 3 controls both reset and powerdown, we rename it to reset. Fix
the polarity of this, as it is a low active signal and not an high active.
As at it, rename the mipi endpoint in the example to be coherent with the a real
case that will be introduce for imx7 media driver.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
---
Documentation/devicetree/bindings/media/i2c/ov2680.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
index e5d8f130309d..11e925ed9dad 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov2680.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
@@ -9,8 +9,8 @@ Required Properties:
- AVDD-supply: Analog voltage supply.
Optional Properties:
-- powerdown-gpios: reference to the GPIO connected to the powerdown pin,
- if any. This is an active high signal to the OV2680.
+- reset-gpios: reference to the GPIO connected to the powerdown/reset pin,
+ if any. This is an active low signal to the OV2680.
The device node must contain one 'port' child node for its digital output
video port, and this port must have a single endpoint in accordance with
@@ -30,14 +30,14 @@ Example:
reg = <0x36>;
clocks = <&osc>;
clock-names = "xvclk";
- powerdown-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
DOVDD-supply = <&sw2_reg>;
DVDD-supply = <&sw2_reg>;
AVDD-supply = <®_peri_3p15v>;
port {
- ov2680_mipi_ep: endpoint {
- remote-endpoint = <&mipi_sensor_ep>;
+ ov2680_to_mipi: endpoint {
+ remote-endpoint = <&mipi_from_sensor>;
clock-lanes = <0>;
data-lanes = <1>;
};
--
2.17.0
next prev parent reply other threads:[~2018-05-07 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:56 [PATCH 0/4] media: ov2680: follow up from initial version Rui Miguel Silva
2018-05-07 15:56 ` [PATCH 1/4] media: ov2680: dt: add voltage supplies as required Rui Miguel Silva
2018-05-07 15:56 ` Rui Miguel Silva [this message]
2018-05-07 15:56 ` [PATCH 3/4] media: ov2680: rename powerdown gpio and fix polarity Rui Miguel Silva
2018-05-07 15:56 ` [PATCH 4/4] media: ov2680: add regulators to supply control Rui Miguel Silva
2018-05-08 13:29 ` [PATCH 0/4] media: ov2680: follow up from initial version Fabio Estevam
2018-05-08 13:52 ` Rui Miguel Silva
2018-05-08 13:55 ` Fabio Estevam
2018-05-08 20:03 ` Sakari Ailus
2018-05-09 11:03 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507155655.1555-3-rui.silva@linaro.org \
--to=rui.silva@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.harkin@linaro.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).