From: Rob Herring <robh@kernel.org>
To: Christophe Roullier <christophe.roullier@st.com>
Cc: mark.rutland@arm.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, peppe.cavallaro@st.com,
devicetree@vger.kernel.org, andrew@lunn.ch,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon
Date: Mon, 7 May 2018 11:35:37 -0500 [thread overview]
Message-ID: <20180507163537.GA15212@rob-hp-laptop> (raw)
In-Reply-To: <1525270723-18241-9-git-send-email-christophe.roullier@st.com>
On Wed, May 02, 2018 at 04:18:43PM +0200, Christophe Roullier wrote:
> This patch describes syscon DT bindings.
>
> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
> ---
> Documentation/devicetree/bindings/arm/stm32.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/stm32.txt b/Documentation/devicetree/bindings/arm/stm32.txt
> index 6808ed9..06e3834 100644
> --- a/Documentation/devicetree/bindings/arm/stm32.txt
> +++ b/Documentation/devicetree/bindings/arm/stm32.txt
> @@ -8,3 +8,7 @@ using one of the following compatible strings:
> st,stm32f746
> st,stm32h743
> st,stm32mp157
> +
> +Required nodes:
> +- syscon: the soc bus node must have a system controller node pointing to the
> + global control registers, with the compatible string "syscon";
You misunderstood my prior comment. 'syscon' alone is not valid. You
need SoC specific compatible string for it and 'stm32' is not SoC
specific. IOW, the compatible property for a syscon should imply every
single register field in the block.
Rob
next prev parent reply other threads:[~2018-05-07 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 14:18 [PATCH V2 0/8] net: ethernet: stmmac: add support for stm32mp1 Christophe Roullier
2018-05-02 14:18 ` [PATCH V2 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c Christophe Roullier
2018-05-02 14:18 ` [PATCH V2 2/8] dt-bindings: stm32-dwmac: add support of MPU families Christophe Roullier
2018-05-07 16:37 ` Rob Herring
2018-05-02 14:18 ` [PATCH V2 3/8] ARM: dts: stm32: add ethernet pins to stm32mp157c Christophe Roullier
2018-05-02 14:18 ` [PATCH V2 4/8] ARM: dts: stm32: Add syscfg on stm32mp1 Christophe Roullier
2018-05-07 16:36 ` Rob Herring
2018-05-02 14:18 ` [PATCH V2 5/8] ARM: dts: stm32: Add ethernet dwmac " Christophe Roullier
2018-05-02 14:18 ` [PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible Christophe Roullier
2018-05-02 14:41 ` Jose Abreu
2018-05-02 15:16 ` Christophe ROULLIER
2018-05-02 14:18 ` [PATCH V2 7/8] ARM: dts: stm32: add support of ethernet on stm32mp157c-ev1 Christophe Roullier
2018-05-02 14:18 ` [PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon Christophe Roullier
2018-05-07 16:35 ` Rob Herring [this message]
2018-05-15 16:19 ` Christophe ROULLIER
2018-05-17 12:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507163537.GA15212@rob-hp-laptop \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=christophe.roullier@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox