devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	thor.thayer@linux.intel.com, catalin.marinas@arm.com,
	will.deacon@arm.com, dinguyen@kernel.org, robh+dt@kernel.org,
	mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org
Subject: Re: [PATCHv2 3/3] arm64: dts: stratix10: add sdram ecc
Date: Mon, 7 May 2018 18:59:43 +0200	[thread overview]
Message-ID: <20180507165943.GE733@pd.tnic> (raw)
In-Reply-To: <1524854238-19394-4-git-send-email-thor.thayer@linux.intel.com>

On Fri, Apr 27, 2018 at 01:37:18PM -0500, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
> 
> Add the Stratix10 ECC Manager and SDRAM EDAC nodes to the
> device tree.
> 
> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> ---
> v2  Remove unused SysMan syscon
>     Remove unused SDRAM ECC register defines
>     Remove unused address, size and range from device tree.
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index c89d0c307f8d..688391f3bf78 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -387,5 +387,17 @@
>  			resets = <&rst WATCHDOG3_RESET>;
>  			status = "disabled";
>  		};
> +
> +		eccmgr {
> +			compatible = "altr,socfpga-s10-ecc-manager";
> +			interrupts = <0 15 4>, <0 95 4>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +
> +			sdramedac {
> +				compatible = "altr,sdram-edac-s10";
> +				interrupts = <16 4>, <48 4>;
> +			};
> +		};
>  	};
>  };
> -- 
> 2.7.4
> 
> --

Hey Rob,

ACK here too?

Also, this one:

https://lkml.kernel.org/r/1525203036-21774-1-git-send-email-thor.thayer@linux.intel.com

?

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-05-07 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 18:37 [PATCHv2 0/3] Add SDRAM ECC support for Stratix10 thor.thayer
2018-04-27 18:37 ` [PATCHv2 1/3] Documentation: dt: socfpga: Add Stratix10 ECC Manager binding thor.thayer
2018-05-01 12:54   ` Rob Herring
2018-04-27 18:37 ` [PATCHv2 2/3] edac: altera: Add support for Stratix10 SDRAM EDAC thor.thayer
2018-04-27 18:37 ` [PATCHv2 3/3] arm64: dts: stratix10: add sdram ecc thor.thayer
2018-05-07 16:59   ` Borislav Petkov [this message]
2018-05-07 20:50     ` Dinh Nguyen
2018-05-07 21:10       ` Dinh Nguyen
2018-05-08  8:53         ` Borislav Petkov
2018-05-08 19:27           ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507165943.GE733@pd.tnic \
    --to=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=thor.thayer@linux.intel.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).