From: Rob Herring <robh@kernel.org>
To: Bastian Stender <bst@pengutronix.de>
Cc: Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Michael Lawnick <ml.lawnick@gmx.de>,
kernel@pengutronix.de
Subject: Re: [PATCH v2 1/3] dt: bindings: i2c-mux-pca954x: add mux-locked property
Date: Mon, 7 May 2018 12:01:24 -0500 [thread overview]
Message-ID: <20180507170124.GA11249@rob-hp-laptop> (raw)
In-Reply-To: <20180504130449.13730-1-bst@pengutronix.de>
On Fri, May 04, 2018 at 03:04:47PM +0200, Bastian Stender wrote:
> Signed-off-by: Bastian Stender <bst@pengutronix.de>
Commit message needed.
> ---
> .../devicetree/bindings/i2c/i2c-mux-pca954x.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 34d91501342e..864ac91f8c1c 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -36,6 +36,22 @@ Optional Properties:
> - first cell is the pin number
> - second cell is used to specify flags.
> See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> + - mux-locked: If present, explicitly allow unrelated I2C transactions on the
> + parent I2C adapter at these times:
> + + during setup of the multiplexer
> + + between setup of the multiplexer and the child bus I2C transaction
> + + between the child bus I2C transaction and releasing of the multiplexer
> + + during releasing of the multiplexer
> +
> + However, I2C transactions to devices behind all I2C multiplexers connected
> + to the same parent adapter that this multiplexer is connected to are blocked
> + for the full duration of the complete multiplexed I2C transaction (i.e.
> + including the times covered by the above list).
> + If mux-locked is not present, the multiplexer is assumed to be parent-locked.
> + This means that no unrelated I2C transactions are allowed on the parent I2C
> + adapter for the complete multiplexed I2C transaction.
> + The properties of mux-locked and parent-locked multiplexers are discussed
> + in more detail in Documentation/i2c/i2c-topology.
Why are you copy-n-pasting paragraphs for an already defined property?
Just refer to the definition.
Rob
prev parent reply other threads:[~2018-05-07 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 13:04 [PATCH v2 1/3] dt: bindings: i2c-mux-pca954x: add mux-locked property Bastian Stender
2018-05-04 13:04 ` [PATCH v2 2/3] i2c: Documentation: i2c-topology: i2c-mux-pca954x can be mux-locked via dt Bastian Stender
2018-05-04 13:04 ` [PATCH v2 3/3] i2c: mux: pca954x: add option to use as mux-locked Bastian Stender
2018-05-07 7:04 ` Peter Rosin
2018-05-04 13:10 ` [PATCH v2 1/3] dt: bindings: i2c-mux-pca954x: add mux-locked property Bastian Stender
2018-05-07 9:07 ` Peter Rosin
2018-05-14 12:26 ` Bastian Stender
2018-05-14 13:16 ` Peter Rosin
2018-05-07 17:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507170124.GA11249@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=ml.lawnick@gmx.de \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox