devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Christina Quast <cquast@baylibre.com>
Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Oleg Kokorin <ole2mail@mail.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: am335x: Replaced register offsets with defines
Date: Mon, 7 May 2018 14:02:25 -0700	[thread overview]
Message-ID: <20180507210225.GS98604@atomide.com> (raw)
In-Reply-To: <20180505085921.5513-3-cquast@baylibre.com>

Hi,

Thanks for updating these, adding Linus Walleij to Cc too.

* Christina Quast <cquast@baylibre.com> [180505 09:02]:
> The defines are taken from dt-bindings/pinctrl/am335x.h

If we're going to replace all of these, I'd go a step further
where we make pinctrl-single use the newish #pinctrl-cells but
set it to 2 instead of 1. Then set the pull flags as one value
using the generic pinctrl defines and the second value being
the selected mux mode.

Then the offset really should be from the padconf mux area,
not from the control module base. And then we would just have
a new macro for these being:

AM33XX_PINCTRL(AM335X_PIN_UART1_RXD, PIN_INPUT, MUX_MODE0)

Where the PIN_INPUT ideally would be a Linux generic define.

Otherwise we'd be churning these same files over and
over.

Regards,

Tony

      reply	other threads:[~2018-05-07 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05  8:59 [PATCH v2 0/2] Add macro defines for AM335x Christina Quast
2018-05-05  8:59 ` [PATCH v2 1/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2018-05-07 17:05   ` Rob Herring
2018-05-05  8:59 ` [PATCH v2 2/2] ARM: dts: am335x: Replaced register offsets with defines Christina Quast
2018-05-07 21:02   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507210225.GS98604@atomide.com \
    --to=tony@atomide.com \
    --cc=cquast@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ole2mail@mail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).