devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	"Ivan T . Ivanov" <ivan.ivanov@linaro.org>,
	linux-arm-msm@vger.kernel.org
Subject: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
Date: Tue,  8 May 2018 10:09:51 -0500	[thread overview]
Message-ID: <20180508150952.24562-3-robh@kernel.org> (raw)
In-Reply-To: <20180508150952.24562-1-robh@kernel.org>

The ETF input should be connected to the funnel output, and the ETF
output should be connected to the replicator input. The labels are wrong
and these got swapped:

Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional

Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>
Cc: David Brown <david.brown@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 66b318e1de80..aef814b2dc9e 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1191,14 +1191,14 @@
 
 				port@0 {
 					reg = <0>;
-					etf_out: endpoint {
+					etf_in: endpoint {
 						slave-mode;
 						remote-endpoint = <&funnel0_out>;
 					};
 				};
 				port@1 {
 					reg = <0>;
-					etf_in: endpoint {
+					etf_out: endpoint {
 						remote-endpoint = <&replicator_in>;
 					};
 				};
-- 
2.17.0

  parent reply	other threads:[~2018-05-08 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 15:09 [PATCH] arm64: dts: juno: fix OF graph endpoint node names Rob Herring
2018-05-08 15:09 ` [PATCH] arm64: dts: juno: fix missing Coresight STM graph connection Rob Herring
2018-05-08 15:09 ` Rob Herring [this message]
2018-05-23 20:29   ` [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections Rob Herring
2018-05-24  4:48     ` Ivan T. Ivanov
2018-05-24 16:32       ` Mathieu Poirier
2018-05-25 22:46         ` Andy Gross
2018-05-08 15:09 ` [PATCH] arm64: dts: sprd: fix typo in 'remote-endpoint' Rob Herring
2018-05-09  1:58   ` Chunyan Zhang
2018-05-23 20:30     ` Rob Herring
2018-05-24  5:27       ` Baolin Wang
2018-05-25  2:36       ` Chunyan Zhang
2018-05-25 22:11         ` Olof Johansson
2018-05-08 15:15 ` [PATCH] arm64: dts: juno: fix OF graph endpoint node names Liviu Dudau
2018-05-09 16:34 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508150952.24562-3-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivan.ivanov@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).