From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: atmel: graph_child_address warning fixes
Date: Tue, 8 May 2018 23:04:14 +0200 [thread overview]
Message-ID: <20180508230414.23a2f201@bbrezillon> (raw)
In-Reply-To: <20180508135930.5768-1-robh@kernel.org>
On Tue, 8 May 2018 08:59:25 -0500
Rob Herring <robh@kernel.org> wrote:
> Addresses for graph ports and endpoints are not necessary when
> there's only a single child. Fix the following warnings removing
> unnecessary addresses on OF graph nodes:
>
> Warning (graph_child_address): /ahb/apb/hlcdc@f0030000/hlcdc-display-controller: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> Warning (graph_child_address): /ahb/apb/hlcdc@f0030000/hlcdc-display-controller/port@0: graph node has single child node 'endpoint', #address-cells/#size-cells are not necessary
> Warning (graph_child_address): /ahb/apb/isi@f0034000/port: graph node has single child node 'endpoint', #address-cells/#size-cells are not necessary
> Warning (graph_child_address): /panel/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts | 15 ++++-----------
> arch/arm/boot/dts/at91sam9g45.dtsi | 2 --
> arch/arm/boot/dts/at91sam9n12.dtsi | 8 +-------
> arch/arm/boot/dts/at91sam9n12ek.dts | 14 ++++----------
> arch/arm/boot/dts/at91sam9x5_lcd.dtsi | 7 +------
> arch/arm/boot/dts/at91sam9x5dm.dtsi | 13 ++++---------
> arch/arm/boot/dts/sama5d3.dtsi | 2 --
> arch/arm/boot/dts/sama5d3_lcd.dtsi | 8 +-------
> arch/arm/boot/dts/sama5d4.dtsi | 8 +-------
For the hlcdc changes
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
I'll update the DT bindinds doc accordingly.
Thanks,
Boris
> 9 files changed, 16 insertions(+), 61 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts b/arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts
> index fe05aaa7ac87..72c3b077fb46 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4evk.dts
> @@ -49,9 +49,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
>
> - port@0 {
> - hlcdc_panel_output: endpoint@0 {
> - reg = <0>;
> + port {
> + hlcdc_panel_output: endpoint {
> remote-endpoint = <&panel_input>;
> };
> };
> @@ -144,16 +143,10 @@
> /* Actually Ampire 800480R2 */
> compatible = "foxlink,fl500wvr00-a0t", "simple-panel";
> backlight = <&backlight>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "okay";
>
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - panel_input: endpoint@0 {
> - reg = <0>;
> + port {
> + panel_input: endpoint {
> remote-endpoint = <&hlcdc_panel_output>;
> };
> };
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 1ee25a475be8..36729e3f2899 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -1114,8 +1114,6 @@
> clock-names = "isi_clk";
> status = "disabled";
> port {
> - #address-cells = <1>;
> - #size-cells = <0>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
> index 37cb81f457b5..a071fccb729b 100644
> --- a/arch/arm/boot/dts/at91sam9n12.dtsi
> +++ b/arch/arm/boot/dts/at91sam9n12.dtsi
> @@ -475,13 +475,7 @@
>
> hlcdc-display-controller {
> compatible = "atmel,hlcdc-display-controller";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0>;
> + port {
> };
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index c43095c5cb5c..eb0c1e11fa4d 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -134,9 +134,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
>
> - port@0 {
> - hlcdc_panel_output: endpoint@0 {
> - reg = <0>;
> + port {
> + hlcdc_panel_output: endpoint {
> remote-endpoint = <&panel_input>;
> };
> };
> @@ -246,13 +245,8 @@
> #size-cells = <0>;
> status = "okay";
>
> - port@0 {
> - reg = <0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - panel_input: endpoint@0 {
> - reg = <0>;
> + port {
> + panel_input: endpoint {
> remote-endpoint = <&hlcdc_panel_output>;
> };
> };
> diff --git a/arch/arm/boot/dts/at91sam9x5_lcd.dtsi b/arch/arm/boot/dts/at91sam9x5_lcd.dtsi
> index 1629db9dd563..e243dff67a67 100644
> --- a/arch/arm/boot/dts/at91sam9x5_lcd.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5_lcd.dtsi
> @@ -23,13 +23,8 @@
>
> hlcdc-display-controller {
> compatible = "atmel,hlcdc-display-controller";
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0>;
> + port {
> };
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9x5dm.dtsi b/arch/arm/boot/dts/at91sam9x5dm.dtsi
> index 34c089fe0bc0..5aea8fd09ad6 100644
> --- a/arch/arm/boot/dts/at91sam9x5dm.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5dm.dtsi
> @@ -29,9 +29,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
>
> - port@0 {
> - hlcdc_panel_output: endpoint@0 {
> - reg = <0>;
> + port {
> + hlcdc_panel_output: endpoint {
> remote-endpoint = <&panel_input>;
> };
> };
> @@ -80,12 +79,8 @@
> #size-cells = <0>;
> status = "disabled";
>
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - panel_input: endpoint@0 {
> - reg = <0>;
> + port {
> + panel_input: endpoint {
> remote-endpoint = <&hlcdc_panel_output>;
> };
> };
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index eae5e1ee9cd8..2c51042e1f6b 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -239,8 +239,6 @@
> clock-names = "isi_clk";
> status = "disabled";
> port {
> - #address-cells = <1>;
> - #size-cells = <0>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/sama5d3_lcd.dtsi b/arch/arm/boot/dts/sama5d3_lcd.dtsi
> index be7cfefc6c31..2d042d7ec531 100644
> --- a/arch/arm/boot/dts/sama5d3_lcd.dtsi
> +++ b/arch/arm/boot/dts/sama5d3_lcd.dtsi
> @@ -23,13 +23,7 @@
>
> hlcdc-display-controller {
> compatible = "atmel,hlcdc-display-controller";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0>;
> + port {
> };
> };
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 0cf9beddd556..90d7b64915ec 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -333,13 +333,7 @@
>
> hlcdc-display-controller {
> compatible = "atmel,hlcdc-display-controller";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0>;
> + port {
> };
> };
>
prev parent reply other threads:[~2018-05-08 21:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 13:59 [PATCH] arm: dts: atmel: graph_child_address warning fixes Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx: fix IPU OF graph endpoint node names Rob Herring
2018-05-08 14:06 ` Fabio Estevam
2018-05-08 15:22 ` Rob Herring
2018-05-11 8:35 ` Shawn Guo
2018-05-08 14:19 ` Philipp Zabel
2018-05-08 15:26 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx53: Fix LDB OF graph warning Rob Herring
2018-05-08 14:16 ` Philipp Zabel
2018-05-11 8:47 ` Shawn Guo
2018-05-08 13:59 ` [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000 Rob Herring
2018-05-15 18:11 ` Tony Lindgren
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OMAP3 CM-T3x OF graph video connectors Rob Herring
2018-05-15 18:11 ` Tony Lindgren
2018-05-08 20:18 ` [PATCH] arm: dts: atmel: graph_child_address warning fixes Boris Brezillon
2018-05-08 20:41 ` Rob Herring
2018-05-08 21:00 ` Boris Brezillon
2018-05-08 20:50 ` Boris Brezillon
2018-05-08 21:04 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508230414.23a2f201@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).