From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH] iio: adc: stm32-dfsdm: Add support for stm32mp1 Date: Sat, 12 May 2018 10:33:24 +0100 Message-ID: <20180512103324.5068c893@archlinux> References: <1525266323-4922-1-git-send-email-fabrice.gasnier@st.com> <20180507205151.GA25321@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180507205151.GA25321@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Fabrice Gasnier , alexandre.torgue@st.com, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, benjamin.gaignard@linaro.org, arnaud.pouliquen@st.com List-Id: devicetree@vger.kernel.org On Mon, 7 May 2018 15:51:51 -0500 Rob Herring wrote: > On Wed, May 02, 2018 at 03:05:23PM +0200, Fabrice Gasnier wrote: > > Add support for DFSDM (Digital Filter For Sigma Delta Modulators) > > to STM32MP1. This variant is close to STM32H7 DFSDM, it implements > > 6 filter instances. Registers map is also increased. > > > > Signed-off-by: Fabrice Gasnier > > --- > > .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 7 +++++-- > > drivers/iio/adc/stm32-dfsdm-core.c | 21 +++++++++++++++++++++ > > 2 files changed, 26 insertions(+), 2 deletions(-) > > Reviewed-by: Rob Herring Applied. Whilst doing this I note that I'm getting a few sparse warnings for this driver that would be nice to clean up... CHECK drivers/iio/adc/stm32-dfsdm-adc.c drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void) drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void) Which is mystifying at first glance... Something deep and dirty in the min macro but I can't see what.. drivers/iio/adc/stm32-dfsdm-adc.c:680:5: warning: symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static? drivers/iio/adc/stm32-dfsdm-adc.c:703:5: warning: symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static? Are rather more obvious