* [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs
@ 2018-05-11 20:18 Sergei Shtylyov
2018-05-11 20:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-05-11 20:18 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
Hello!
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20180511-v4.17-rc4' tag. I'm fixing the issue in the EtherAVB
device nodes in the R8A779{7|8}0 device trees that missed the "status" prop,
usually disabling the SoC devices in anticipation that the board device trees
enable the devices according to their needs. There should be no issues with
the current R8A779{7|8}0 board device trees, as all of them use EtherAVB
anyway, so I'm sending the patches generated against the 'devel' branch...
[1/2] arm64: dts: renesas: r8a77970: disable EtherAVB
[2/2] arm64: dts: renesas: r8a77980: disable EtherAVB
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB
2018-05-11 20:18 [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Sergei Shtylyov
@ 2018-05-11 20:21 ` Sergei Shtylyov
2018-05-11 20:23 ` [PATCH 2/2] arm64: dts: renesas: r8a77980: " Sergei Shtylyov
2018-05-13 8:23 ` [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-05-11 20:21 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
When adding the R8A77970 EtherAVB device I failed to notice that it does
not have the usual "status" property disabling the described devices in
anticipation that the board device trees enable the devices according to
their needs. This causes the EtherAVB driver to successfully probe despite
e.g. the needed pins not having been configured -- luckily, "eth<n>" device
can't be opened anyway...
Fixes: bea2ab136eaa ("arm64: dts: renesas: r8a77970: add EtherAVB support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 +
1 file changed, 1 insertion(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -473,6 +473,7 @@
iommus = <&ipmmu_rt 3>;
#address-cells = <1>;
#size-cells = <0>;
+ status = "disabled";
};
scif0: serial@e6e60000 {
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: r8a77980: disable EtherAVB
2018-05-11 20:18 [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Sergei Shtylyov
2018-05-11 20:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB Sergei Shtylyov
@ 2018-05-11 20:23 ` Sergei Shtylyov
2018-05-13 8:23 ` [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-05-11 20:23 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Mark Rutland, Magnus Damm, linux-arm-kernel
When adding the R8A77980 EtherAVB device I failed to notice that it does
not have the usual "status" property disabling the described devices in
anticipation that the board device trees enable the devices according to
their needs. This causes the EtherAVB driver to successfully probe despite
e.g. the needed pins not having been configured -- luckily, "eth<n>" device
can't be opened anyway...
Fixes: bf6f90832f81 ("arm64: dts: renesas: r8a77980: add EtherAVB support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 +
1 file changed, 1 insertion(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -244,6 +244,7 @@
phy-mode = "rgmii";
#address-cells = <1>;
#size-cells = <0>;
+ status = "disabled";
};
scif0: serial@e6e60000 {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs
2018-05-11 20:18 [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Sergei Shtylyov
2018-05-11 20:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB Sergei Shtylyov
2018-05-11 20:23 ` [PATCH 2/2] arm64: dts: renesas: r8a77980: " Sergei Shtylyov
@ 2018-05-13 8:23 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-05-13 8:23 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
On Fri, May 11, 2018 at 11:18:36PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
> 'renesas-devel-20180511-v4.17-rc4' tag. I'm fixing the issue in the EtherAVB
> device nodes in the R8A779{7|8}0 device trees that missed the "status" prop,
> usually disabling the SoC devices in anticipation that the board device trees
> enable the devices according to their needs. There should be no issues with
> the current R8A779{7|8}0 board device trees, as all of them use EtherAVB
> anyway, so I'm sending the patches generated against the 'devel' branch...
>
> [1/2] arm64: dts: renesas: r8a77970: disable EtherAVB
> [2/2] arm64: dts: renesas: r8a77980: disable EtherAVB
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-13 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-11 20:18 [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Sergei Shtylyov
2018-05-11 20:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77970: disable EtherAVB Sergei Shtylyov
2018-05-11 20:23 ` [PATCH 2/2] arm64: dts: renesas: r8a77980: " Sergei Shtylyov
2018-05-13 8:23 ` [PATCH 0/2] Disable EtherAVB by default on R8A779{7|8}0 SoCs Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).