* [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
@ 2018-05-14 18:29 Fabio Estevam
2018-05-14 18:29 ` [PATCH 2/2] ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: " Fabio Estevam
2018-05-15 8:06 ` [PATCH 1/2] ARM: dts: imx51-babbage: " Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-05-14 18:29 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy@0: duplicate unit-address (also used in node /usbphy/usbh1phy@0)
Fix it by moving the USB PHY node outside of simple-bus and drop the
unneeded unit-address.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
index b8ca73d..de46906 100644
--- a/arch/arm/boot/dts/imx51-babbage.dts
+++ b/arch/arm/boot/dts/imx51-babbage.dts
@@ -170,20 +170,13 @@
mux-ext-port = <3>;
};
- usbphy {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "simple-bus";
-
- usbh1phy: usbh1phy@0 {
- compatible = "usb-nop-xceiv";
- reg = <0>;
- clocks = <&clk_usb>;
- clock-names = "main_clk";
- reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
- vcc-supply = <&vusb_reg>;
- #phy-cells = <0>;
- };
+ usbh1phy: usbphy1 {
+ compatible = "usb-nop-xceiv";
+ clocks = <&clk_usb>;
+ clock-names = "main_clk";
+ reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vusb_reg>;
+ #phy-cells = <0>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: Fix USB PHY duplicate unit-address
2018-05-14 18:29 [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address Fabio Estevam
@ 2018-05-14 18:29 ` Fabio Estevam
2018-05-15 8:06 ` [PATCH 1/2] ARM: dts: imx51-babbage: " Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-05-14 18:29 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Currently the following DTC warning is seen with W=1:
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dtb: Warning (unique_unit_address): /usbphy/usbphy@0: duplicate unit-address (also used in node /usbphy/usbh1phy@0)
Fix it by moving the USB PHY node outside of simple-bus and drop the
unneeded unit-address.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
.../arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
index b3d952f..29b0b7b 100644
--- a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
+++ b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
@@ -83,19 +83,12 @@
fsl,mux-ext-port = <3>;
};
- usbphy {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "simple-bus";
-
- usbh1phy: usbh1phy@0 {
- compatible = "usb-nop-xceiv";
- reg = <0>;
- clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
- clock-names = "main_clk";
- clock-frequency = <19200000>;
- #phy-cells = <0>;
- };
+ usbh1phy: usbphy {
+ compatible = "usb-nop-xceiv";
+ clocks = <&clks IMX5_CLK_USB_PHY_GATE>;
+ clock-names = "main_clk";
+ clock-frequency = <19200000>;
+ #phy-cells = <0>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
2018-05-14 18:29 [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address Fabio Estevam
2018-05-14 18:29 ` [PATCH 2/2] ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: " Fabio Estevam
@ 2018-05-15 8:06 ` Shawn Guo
2018-05-22 22:45 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2018-05-15 8:06 UTC (permalink / raw)
To: Fabio Estevam, robh+dt; +Cc: Fabio Estevam, devicetree, linux-arm-kernel
On Mon, May 14, 2018 at 03:29:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Currently the following DTC warning is seen with W=1:
>
> arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy@0: duplicate unit-address (also used in node /usbphy/usbh1phy@0)
>
> Fix it by moving the USB PHY node outside of simple-bus and drop the
> unneeded unit-address.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> index b8ca73d..de46906 100644
> --- a/arch/arm/boot/dts/imx51-babbage.dts
> +++ b/arch/arm/boot/dts/imx51-babbage.dts
> @@ -170,20 +170,13 @@
> mux-ext-port = <3>;
> };
>
> - usbphy {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "simple-bus";
> -
> - usbh1phy: usbh1phy@0 {
> - compatible = "usb-nop-xceiv";
> - reg = <0>;
> - clocks = <&clk_usb>;
> - clock-names = "main_clk";
> - reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> - vcc-supply = <&vusb_reg>;
> - #phy-cells = <0>;
> - };
> + usbh1phy: usbphy1 {
> + compatible = "usb-nop-xceiv";
> + clocks = <&clk_usb>;
> + clock-names = "main_clk";
> + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vusb_reg>;
> + #phy-cells = <0>;
This should be considered as a whole together with usbphy in imx51.dtsi.
Also, I would like to get some input from DT folks on how we should name
the node uniquely. @Rob.
Shawn
> };
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address
2018-05-15 8:06 ` [PATCH 1/2] ARM: dts: imx51-babbage: " Shawn Guo
@ 2018-05-22 22:45 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-05-22 22:45 UTC (permalink / raw)
To: Shawn Guo; +Cc: Fabio Estevam, devicetree, Fabio Estevam, linux-arm-kernel
On Tue, May 15, 2018 at 04:06:26PM +0800, Shawn Guo wrote:
> On Mon, May 14, 2018 at 03:29:35PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > Currently the following DTC warning is seen with W=1:
> >
> > arch/arm/boot/dts/imx51-babbage.dtb: Warning (unique_unit_address): /usbphy/usbphy@0: duplicate unit-address (also used in node /usbphy/usbh1phy@0)
> >
> > Fix it by moving the USB PHY node outside of simple-bus and drop the
> > unneeded unit-address.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> > ---
> > arch/arm/boot/dts/imx51-babbage.dts | 21 +++++++--------------
> > 1 file changed, 7 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> > index b8ca73d..de46906 100644
> > --- a/arch/arm/boot/dts/imx51-babbage.dts
> > +++ b/arch/arm/boot/dts/imx51-babbage.dts
> > @@ -170,20 +170,13 @@
> > mux-ext-port = <3>;
> > };
> >
> > - usbphy {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > - compatible = "simple-bus";
> > -
> > - usbh1phy: usbh1phy@0 {
> > - compatible = "usb-nop-xceiv";
> > - reg = <0>;
> > - clocks = <&clk_usb>;
> > - clock-names = "main_clk";
> > - reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> > - vcc-supply = <&vusb_reg>;
> > - #phy-cells = <0>;
> > - };
> > + usbh1phy: usbphy1 {
> > + compatible = "usb-nop-xceiv";
> > + clocks = <&clk_usb>;
> > + clock-names = "main_clk";
> > + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> > + vcc-supply = <&vusb_reg>;
> > + #phy-cells = <0>;
>
> This should be considered as a whole together with usbphy in imx51.dtsi.
> Also, I would like to get some input from DT folks on how we should name
> the node uniquely. @Rob.
'usbphy1' is fine. I don't have a better suggestion...
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 22:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-14 18:29 [PATCH 1/2] ARM: dts: imx51-babbage: Fix USB PHY duplicate unit-address Fabio Estevam
2018-05-14 18:29 ` [PATCH 2/2] ARM: dts: iimx51-eukrea-mbimxsd51-baseboard: " Fabio Estevam
2018-05-15 8:06 ` [PATCH 1/2] ARM: dts: imx51-babbage: " Shawn Guo
2018-05-22 22:45 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).