From: Andrew Lunn <andrew@lunn.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Fugang Duan <fugang.duan@nxp.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Tobias Jordan <Tobias.Jordan@elektrobit.com>,
Russell
Subject: Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node
Date: Wed, 16 May 2018 14:27:52 +0200 [thread overview]
Message-ID: <20180516122752.GC22000@lunn.ch> (raw)
In-Reply-To: <CAMuHMdXfOOgADe1my9Y3s3b9_OsXPjbqq1PPFR9izZWhtPuaFg@mail.gmail.com>
On Wed, May 16, 2018 at 10:54:12AM +0200, Geert Uytterhoeven wrote:
> Hi Florian,
>
> Thanks for your series!
> I like the effect on simplifying drivers.
>
> On Wed, May 16, 2018 at 1:56 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> > This patch series updates of_mdiobus_register() such that when the device_node
> > argument is NULL, it calls mdiobus_register() directly. This is consistent with
> > the behavior of of_mdiobus_register() when CONFIG_OF=n.
>
> IMHO the CONFIG_OF=n behavior of of_mdiobus_register() (which I wasn't
> aware of) is inconsistent with the behavior of other of_*() functions,
> which are just empty stubs.
>
> So I'm wondering if you should do it the other way around, and let
> mdiobus_register() call of_mdiobus_register() if dev->of_node exists?
Hi Geert
dev->of_node is often not the correct OF node. The mdio properties are
often embedded inside a MAC driver, and use an 'mdio' container
node. This container node is needed, not the device node.
> I haven't looked at the ACPI handling, but perhaps this can be moved
> inside mdiobus_register() as well?
The ACPI binding for MDIO and PHYs has not been defined yet.
Andrew
next prev parent reply other threads:[~2018-05-16 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 23:56 [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node Florian Fainelli
2018-05-15 23:56 ` [PATCH net-next v2 1/2] " Florian Fainelli
2018-05-15 23:56 ` [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register() Florian Fainelli
2018-05-16 0:01 ` Grygorii Strashko
2018-05-16 1:57 ` Andy Duan
2018-05-16 6:49 ` Antoine Tenart
2018-05-16 11:01 ` Jose Abreu
2018-05-16 20:20 ` Sergei Shtylyov
2018-05-16 8:54 ` [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node Geert Uytterhoeven
2018-05-16 12:27 ` Andrew Lunn [this message]
2018-05-16 18:21 ` David Miller
2018-05-16 18:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516122752.GC22000@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tobias.Jordan@elektrobit.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.torgue@st.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=geert@linux-m68k.org \
--cc=grygorii.strashko@ti.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).