From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v4 03/12] staging: iio: ad2s1200: Add kernel docs to driver state Date: Sun, 20 May 2018 11:53:59 +0100 Message-ID: <20180520115359.3efc80fe@archlinux> References: <38a9e24e5cdbc98afbf4d06f9848c55c26ce37ff.1526667118.git.davidjulianveenstra@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <38a9e24e5cdbc98afbf4d06f9848c55c26ce37ff.1526667118.git.davidjulianveenstra@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: David Veenstra Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, robh+dt@kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de List-Id: devicetree@vger.kernel.org On Fri, 18 May 2018 20:21:34 +0200 David Veenstra wrote: > Add missing kernel docs to the ad2s1200 driver state. > > Signed-off-by: David Veenstra Nice. Applied, Jonathan > --- > Changes in v4: > - Simplified explanation of lock. > > drivers/staging/iio/resolver/ad2s1200.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c > index 9bdcf0c86217..068aa86e9c11 100644 > --- a/drivers/staging/iio/resolver/ad2s1200.c > +++ b/drivers/staging/iio/resolver/ad2s1200.c > @@ -32,6 +32,14 @@ > /* clock period in nano second */ > #define AD2S1200_TSCLK (1000000000 / AD2S1200_HZ) > > +/** > + * struct ad2s1200_state - driver instance specific data. > + * @lock: protects both the GPIO pins and the rx buffer. > + * @sdev: spi device. > + * @sample: GPIO pin SAMPLE. > + * @rdvel: GPIO pin RDVEL. > + * @rx: buffer for spi transfers. > + */ > struct ad2s1200_state { > struct mutex lock; > struct spi_device *sdev;