public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Silvan Murer <silvan.murer@gmail.com>
Cc: lars@metafoo.de, jic23@kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3] iio: dac: Add support for external reference voltage through the regulator framework.
Date: Tue, 22 May 2018 12:19:03 -0500	[thread overview]
Message-ID: <20180522171903.GA24256@rob-hp-laptop> (raw)
In-Reply-To: <1526775557.32235.33.camel@gmail.com>

On Sun, May 20, 2018 at 02:19:17AM +0200, Silvan Murer wrote:
> Add support for external reference voltage through the regulator framework.
> 
> Signed-off-by: Silvan Murer <silvan.murer@gmail.com>
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> Changes in v3:
> 	- remove extra spaces and tab
> Changes in v2:
> 	- Add 'optional properties' documentation
> 	- Return an error when a regulator is specified
> 	- Use internal reference when no regulator is specified
> 	- Use iio_device_register instead of devm_iio_device_register
> 
> �.../devicetree/bindings/iio/dac/ltc2632.txt��������| 14 +++++

Reviewed-by: Rob Herring <robh@kernel.org>

In the future, please split bindings to separate patch.

> �drivers/iio/dac/ltc2632.c��������������������������| 70 +++++++++++++++++++---
> �2 files changed, 75 insertions(+), 9 deletions(-)

  parent reply	other threads:[~2018-05-22 17:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20  0:19 [PATCH v3] iio: dac: Add support for external reference voltage through the regulator framework Silvan Murer
2018-05-20 10:23 ` Jonathan Cameron
2018-05-21 12:29   ` Silvan Murer
2018-05-22 17:19 ` Rob Herring [this message]
2018-05-23  7:17   ` Silvan Murer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180522171903.GA24256@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=silvan.murer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox