From: Jonathan Cameron <jic23@kernel.org>
To: Silvan Murer <silvan.murer@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] iio: dac: fix missing of_match_table assignment in the LTC 2632 device
Date: Tue, 22 May 2018 18:21:28 +0100 [thread overview]
Message-ID: <20180522182128.3770f50c@archlinux> (raw)
In-Reply-To: <1526905288-28668-2-git-send-email-silvan.murer@gmail.com>
On Mon, 21 May 2018 14:21:27 +0200
Silvan Murer <silvan.murer@gmail.com> wrote:
> Signed-off-by: Silvan Murer <silvan.murer@gmail.com>
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ltc2632.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
> index ac5e05f..d322b78 100644
> --- a/drivers/iio/dac/ltc2632.c
> +++ b/drivers/iio/dac/ltc2632.c
> @@ -276,15 +276,6 @@ static const struct spi_device_id ltc2632_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, ltc2632_id);
>
> -static struct spi_driver ltc2632_driver = {
> - .driver = {
> - .name = "ltc2632",
> - },
> - .probe = ltc2632_probe,
> - .id_table = ltc2632_id,
> -};
> -module_spi_driver(ltc2632_driver);
> -
> static const struct of_device_id ltc2632_of_match[] = {
> {
> .compatible = "lltc,ltc2632-l12",
> @@ -309,6 +300,16 @@ static const struct of_device_id ltc2632_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, ltc2632_of_match);
>
> +static struct spi_driver ltc2632_driver = {
> + .driver = {
> + .name = "ltc2632",
> + .of_match_table = of_match_ptr(ltc2632_of_match),
> + },
> + .probe = ltc2632_probe,
> + .id_table = ltc2632_id,
> +};
> +module_spi_driver(ltc2632_driver);
> +
> MODULE_AUTHOR("Maxime Roussin-Belanger <maxime.roussinbelanger@gmail.com>");
> MODULE_DESCRIPTION("LTC2632 DAC SPI driver");
> MODULE_LICENSE("GPL v2");
next prev parent reply other threads:[~2018-05-22 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 12:21 [PATCH v4 0/2] iio: dac: update ltc2632 device driver Silvan Murer
2018-05-21 12:21 ` [PATCH v4 1/2] iio: dac: fix missing of_match_table assignment in the LTC 2632 device Silvan Murer
2018-05-22 17:21 ` Jonathan Cameron [this message]
2018-05-21 12:21 ` [PATCH v4 2/2] iio: dac: Add support for external reference voltage through the regulator framework Silvan Murer
2018-05-22 17:25 ` Jonathan Cameron
2018-05-23 7:19 ` Silvan Murer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522182128.3770f50c@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=silvan.murer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).