From mboxrd@z Thu Jan 1 00:00:00 1970 From: Can Guo Subject: [PATCH v5 1/3] phy: Power on PHY before start Serdes configuration Date: Wed, 23 May 2018 11:47:10 +0800 Message-ID: <20180523034712.3420-2-cang@codeaurora.org> References: <20180523034712.3420-1-cang@codeaurora.org> Return-path: In-Reply-To: <20180523034712.3420-1-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: subhashj@codeaurora.org, asutoshd@codeaurora.org, vivek.gautam@codeaurora.org, mgautam@codeaurora.org, kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Can Guo List-Id: devicetree@vger.kernel.org PHYs should be powered on before register configuration starts. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 97ef942..9bfdba1 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -1000,6 +1000,12 @@ static int qcom_qmp_phy_com_init(struct qcom_qmp *qmp) SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET); } + /* + * Pull out PHY from POWER DOWN state. + * This is active low enable signal to power-down PHY. + */ + qphy_setbits(pcs, QPHY_POWER_DOWN_CONTROL, cfg->pwrdn_ctrl); + /* Serdes configuration */ qcom_qmp_phy_configure(serdes, cfg->regs, cfg->serdes_tbl, cfg->serdes_tbl_num); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project