From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: KaiChieh Chuang
<kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
wsd_upstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] dt-bindings: soc: update MT6797 power domain
Date: Wed, 23 May 2018 13:27:59 -0500 [thread overview]
Message-ID: <20180523182759.GA12966@rob-hp-laptop> (raw)
In-Reply-To: <1526890186-16219-1-git-send-email-kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Mon, May 21, 2018 at 04:09:46PM +0800, KaiChieh Chuang wrote:
> remove unused power domain in mt6797 and re-index
>
> Signed-off-by: KaiChieh Chuang <kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Mars Cheng <mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> include/dt-bindings/power/mt6797-power.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/include/dt-bindings/power/mt6797-power.h b/include/dt-bindings/power/mt6797-power.h
> index a60c1d8..f96c4e2 100644
> --- a/include/dt-bindings/power/mt6797-power.h
> +++ b/include/dt-bindings/power/mt6797-power.h
> @@ -20,11 +20,6 @@
> #define MT6797_POWER_DOMAIN_MM 3
> #define MT6797_POWER_DOMAIN_AUDIO 4
> #define MT6797_POWER_DOMAIN_MFG_ASYNC 5
> -#define MT6797_POWER_DOMAIN_MFG 6
> -#define MT6797_POWER_DOMAIN_MFG_CORE0 7
> -#define MT6797_POWER_DOMAIN_MFG_CORE1 8
> -#define MT6797_POWER_DOMAIN_MFG_CORE2 9
> -#define MT6797_POWER_DOMAIN_MFG_CORE3 10
> -#define MT6797_POWER_DOMAIN_MJC 11
> +#define MT6797_POWER_DOMAIN_MJC 6
This is an ABI. You can't just change the numbering. You'll cause a
mismatch between existing dtb and new kernel.
Rob
prev parent reply other threads:[~2018-05-23 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 8:09 [PATCH] dt-bindings: soc: update MT6797 power domain KaiChieh Chuang
[not found] ` <1526890186-16219-1-git-send-email-kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-05-23 18:27 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523182759.GA12966@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kaichieh.chuang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wsd_upstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox