From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections Date: Thu, 24 May 2018 07:48:53 +0300 Message-ID: <20180524044853.713.23166@silver> References: <20180508150952.24562-1-robh@kernel.org> <20180508150952.24562-3-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Andy Gross , Rob Herring , devicetree@vger.kernel.org Cc: David Brown , Mathieu Poirier , "Ivan T . Ivanov" , linux-arm-msm List-Id: devicetree@vger.kernel.org Quoting Rob Herring (2018-05-23 23:29:29) > On Tue, May 8, 2018 at 10:09 AM, Rob Herring wrote: > > The ETF input should be connected to the funnel output, and the ETF > > output should be connected to the replicator input. The labels are wrong > > and these got swapped: > > > > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional > > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional > > > > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") > > Cc: Ivan T. Ivanov > > Cc: Mathieu Poirier > > Cc: Andy Gross > > Cc: David Brown > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Ping. Still seeing warnings in -next for these. > Hi Rob, I no longer have access to this hardware and documentation. I am sure that Mathieu and friends will take care for verification of this patch :-) Regards, Ivan