From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Benjamin Lindqvist <benjamin.lindqvist@endian.se>
Cc: Stefan Agner <stefan@agner.ch>,
dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, mturquette@baylibre.com,
sboyd@kernel.org, Lucas Stach <dev@lynxeye.de>,
miquel.raynal@bootlin.com, richard@nod.at, marcel@ziswiler.com,
krzk@kernel.org, digetx@gmail.com, jonathanh@nvidia.com,
pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
Mirza Krak <mirza.krak@gmail.com>,
linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver
Date: Thu, 24 May 2018 13:53:35 +0200 [thread overview]
Message-ID: <20180524135335.6aa0b7a4@bbrezillon> (raw)
In-Reply-To: <CAGefG56khQ2835c2QCteit7FuL_yG+APpj6-4vRRPxztFtkAMA@mail.gmail.com>
Hi Benjamin,
On Thu, 24 May 2018 13:30:14 +0200
Benjamin Lindqvist <benjamin.lindqvist@endian.se> wrote:
> Hi Stefan,
>
> It seems to me that a probe similar to what the BootROM does shouldn't
> be awfully complicated to implement - just cycle through the switch
> cases in case of an ECC error. But I guess that's more of an idea for
> further improvements rather than a comment to the patch set under
> review.
Nope, not really an option, because you're not guaranteed that the NAND
will be used as a boot media, and the first page or first set of pages
might just be erased.
>
> However, I think that allowing for an override of the oobsize
> inference would be a good idea before merging, no? This could just be
> a trivial #ifdef (at least temporarily). If you agree but don't feel
> like doing it yourself, I'd be happy to pitch in. Let me know.
That's why we have nand-ecc-xxx properties in the DT.
Regards,
Boris
next prev parent reply other threads:[~2018-05-24 11:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 12:07 [RESEND PATCH 0/5] mtd: rawnand: add NVIDIA Tegra NAND flash support Stefan Agner
2018-05-22 12:07 ` [RESEND PATCH 1/5] mtd: rawnand: tegra: add devicetree binding Stefan Agner
2018-05-22 17:52 ` Boris Brezillon
2018-05-22 12:07 ` [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver Stefan Agner
2018-05-22 12:16 ` Dmitry Osipenko
2018-05-22 12:19 ` Stefan Agner
2018-05-22 13:34 ` Dmitry Osipenko
2018-05-22 14:28 ` Stefan Agner
2018-05-22 14:53 ` Stefan Agner
2018-05-22 17:55 ` Boris Brezillon
2018-05-23 14:18 ` Boris Brezillon
2018-05-24 8:46 ` Stefan Agner
2018-05-24 8:56 ` Boris Brezillon
2018-05-24 11:09 ` Stefan Agner
2018-05-24 12:23 ` Boris Brezillon
2018-05-24 12:41 ` Boris Brezillon
2018-05-24 22:56 ` Stefan Agner
2018-05-24 12:27 ` Boris Brezillon
2018-05-24 7:40 ` Benjamin Lindqvist
2018-05-24 7:45 ` Benjamin Lindqvist
2018-05-24 11:00 ` Stefan Agner
2018-05-24 11:07 ` Boris Brezillon
2018-05-24 11:30 ` Benjamin Lindqvist
2018-05-24 11:53 ` Boris Brezillon [this message]
2018-05-24 12:19 ` Stefan Agner
2018-05-27 22:04 ` Miquel Raynal
2018-05-28 12:39 ` Stefan Agner
2018-05-31 17:54 ` Stefan Agner
2018-05-31 20:30 ` Boris Brezillon
2018-05-31 21:44 ` Stefan Agner
2018-05-22 12:07 ` [RESEND PATCH 3/5] clk: tegra20: init NDFLASH clock to sensible rate Stefan Agner
2018-05-22 12:07 ` [RESEND PATCH 4/5] ARM: tegra: add Tegra20 NAND flash controller node Stefan Agner
2018-05-22 12:07 ` [RESEND PATCH 5/5] ARM: tegra: enable NAND flash on Colibri T20 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524135335.6aa0b7a4@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=benjamin.lindqvist@endian.se \
--cc=computersforpeace@gmail.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=mirza.krak@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).