devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	andy.yeh@intel.com
Subject: Re: [PATCH v2 1/2] dt-bindings: media: Define "rotation" property for sensors
Date: Fri, 25 May 2018 16:05:03 +0200	[thread overview]
Message-ID: <20180525140503.5hd3lvweu3y46mo2@earth.universe> (raw)
In-Reply-To: <20180525122726.3409-2-sakari.ailus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

Hi,

On Fri, May 25, 2018 at 03:27:25PM +0300, Sakari Ailus wrote:
> Sensors are occasionally mounted upside down to systems such as mobile
> phones or tablets. In order to use such a sensor without having to turn
> every image upside down, most camera sensors support reversing the readout
> order by setting both horizontal and vertical flipping.
> 
> This patch documents the "rotation" property for camera sensors, mirroring
> what is defined for displays in
> Documentation/devicetree/bindings/display/panel/panel.txt .
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

>  Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index 258b8dfddf48..52b7c7b57842 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -85,6 +85,10 @@ Optional properties
>  
>  - lens-focus: A phandle to the node of the focus lens controller.
>  
> +- rotation: The device, typically an image sensor, is not mounted upright,
> +  but a number of degrees counter clockwise. Typical values are 0 and 180
> +  (upside down).
> +
>  
>  Optional endpoint properties
>  ----------------------------
> -- 
> 2.11.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-05-25 14:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 12:27 [PATCH v2 0/2] Define rotation property for camera sensors Sakari Ailus
2018-05-25 12:27 ` [PATCH v2 1/2] dt-bindings: media: Define "rotation" property for sensors Sakari Ailus
2018-05-25 14:05   ` Sebastian Reichel [this message]
2018-05-31  3:33   ` Rob Herring
2018-05-25 12:27 ` [PATCH v2 2/2] smiapp: Support the "upside-down" property Sakari Ailus
2018-05-25 13:40   ` [PATCH v2.1 2/2] smiapp: Support the "rotation" property Sakari Ailus
2018-05-25 13:52     ` [PATCH v2.2 " Sakari Ailus
2018-05-25 14:09       ` Sebastian Reichel
2018-05-25 14:17         ` Sakari Ailus
2018-05-31  3:35       ` Rob Herring
2018-05-25 13:41   ` [PATCH v2 2/2] smiapp: Support the "upside-down" property Sebastian Reichel
2018-05-25 13:52     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525140503.5hd3lvweu3y46mo2@earth.universe \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=andy.yeh@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).