From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 1/6] arm64: dts: amlogic: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 14:10:25 -0700 Message-ID: <20180525211025.c73zdcdtyuvlewng@localhost> References: <2a2eb28da9fecf129f6bc0ab3d3748d9f4d25a29.1527225682.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2a2eb28da9fecf129f6bc0ab3d3748d9f4d25a29.1527225682.git.viresh.kumar@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: arm@kernel.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Carlo Caione , Kevin Hilman , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, May 25, 2018 at 11:10:01AM +0530, Viresh Kumar wrote: > The cooling device properties, like "#cooling-cells" and > "dynamic-power-coefficient", should either be present for all the CPUs > of a cluster or none. If these are present only for a subset of CPUs of > a cluster then things will start falling apart as soon as the CPUs are > brought online in a different order. For example, this will happen > because the operating system looks for such properties in the CPU node > it is trying to bring up, so that it can register a cooling device. > > Add such missing properties. This seems awkward compared to just having one cooling-cells in the /cpus node instead. What's it used for? I don't see any properties in the device nodes on meson-gxm that have any cooling-foo cells in them? So why should #cooling-cells be needed? -Olof