public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod <vkoul@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>, Jiafei Pan <jiafei.pan@nxp.com>,
	Jiaheng Fan <jiaheng.fan@nxp.com>
Subject: Re: [v5 1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT
Date: Tue, 29 May 2018 15:51:21 +0530	[thread overview]
Message-ID: <20180529102121.GK5666@vkoul-mobl> (raw)
In-Reply-To: <AM6PR0402MB3382F1DC777AD2AB106C57EEE26D0@AM6PR0402MB3382.eurprd04.prod.outlook.com>

On 29-05-18, 10:14, Wen He wrote:
> > 
> > Well that patch seems to do a bit more than replace DMA_IN/OUT by
> > FSL_DMA_IN/OUT care to explain those. best would be to do a patch which
> > does replace and then add new things in separate patch, easier to review
> > 
> 
> What does means?
> This also a patch.

You cna do only replace DMA_IN/OUT by FSL_DMA_IN/OUT in this patch. Second patch
can add additional macros you have added and explain what they do and why they
are needed

-- 
~Vinod

  reply	other threads:[~2018-05-29 10:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 11:19 [v5 1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Wen He
2018-05-25 11:19 ` [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Wen He
2018-05-29  7:07   ` Vinod
2018-05-29  9:59     ` Wen He
2018-05-29 10:19       ` Vinod
2018-05-29 10:38         ` Wen He
2018-05-30 10:27           ` Vinod Koul
2018-05-31  1:58             ` Wen He
2018-06-05 16:28               ` Vinod
2018-06-11  8:14                 ` Wen He
2018-06-14  2:15                   ` Wen He
2018-06-14  7:26                     ` Vinod
2018-05-30 18:51   ` Li Yang
2018-06-04  9:53     ` Wen He
2018-06-05 16:30       ` Vinod
2018-06-05 17:24         ` Li Yang
2018-06-12  4:00           ` Vinod
2018-06-12 16:32             ` Li Yang
2018-05-25 11:19 ` [v5 3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA controller bindings Wen He
2018-05-31  0:49   ` Rob Herring
2018-05-25 11:19 ` [v5 4/6] arm64: dts: ls1043a: add qdma device tree nodes Wen He
2018-05-25 11:19 ` [v5 5/6] arm64: dts: ls1046a: " Wen He
2018-05-25 11:19 ` [v5 6/6] arm: dts: ls1021a: " Wen He
2018-05-29  4:49 ` [v5 1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Vinod
2018-05-29 10:14   ` Wen He
2018-05-29 10:21     ` Vinod [this message]
2018-05-29 10:22       ` Wen He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529102121.GK5666@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=jiafei.pan@nxp.com \
    --cc=jiaheng.fan@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox