From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <daniel@zonque.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, kuninori.morimoto.gx@renesas.com
Subject: Re: [PATCH 1/3] ASoC: simple-card: set cpu dai clk in hw_params
Date: Tue, 29 May 2018 12:32:43 +0100 [thread overview]
Message-ID: <20180529113243.GD23509@sirena.org.uk> (raw)
In-Reply-To: <fd307a0e-483c-6e64-5017-ecdf98814b1d@zonque.org>
[-- Attachment #1.1: Type: text/plain, Size: 775 bytes --]
On Tue, May 29, 2018 at 01:17:45PM +0200, Daniel Mack wrote:
> On Tuesday, May 29, 2018 01:16 PM, Mark Brown wrote:
> > On Mon, May 28, 2018 at 09:35:01PM +0200, Daniel Mack wrote:
> > > + if (dai_props->cpu_dai.clk)
> > > + clk_set_rate(dai_props->cpu_dai.clk, mclk);
> > We're ignoring the return value here.
> On purpose actually. Not all clocks might be settable, and in that case,
> this is a no-op. You think we should bail or warn?
If we need to set the rate and fail to set it then clearly we shouldn't
just carry on ignoring the error. You might want some more involved
logic there around checking if it's actually a rate change before you
error out, and possibly some logic to carry on with whatever the rate is
and a reduced set of resulting sample rates.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-05-29 11:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 19:35 [PATCH 0/3] ASoC: make simple-card a bit more versatile Daniel Mack
2018-05-28 19:35 ` [PATCH 1/3] ASoC: simple-card: set cpu dai clk in hw_params Daniel Mack
2018-05-29 1:38 ` Kuninori Morimoto
2018-05-29 4:26 ` Daniel Mack
2018-05-29 11:16 ` Mark Brown
2018-05-29 11:17 ` Daniel Mack
2018-05-29 11:32 ` Mark Brown [this message]
2018-05-29 20:31 ` Daniel Mack
2018-05-28 19:35 ` [PATCH 2/3] ASoC: simple-card: make sysclk index configurable Daniel Mack
2018-05-29 1:35 ` Kuninori Morimoto
2018-05-29 4:34 ` Daniel Mack
2018-05-29 11:24 ` Mark Brown
2018-05-29 20:23 ` Daniel Mack
2018-05-30 9:49 ` Mark Brown
2018-05-31 17:02 ` Rob Herring
2018-05-31 20:03 ` Daniel Mack
2018-06-01 14:21 ` Rob Herring
2018-05-28 19:35 ` [PATCH 3/3] ASoC: simple-card: add support for clock divider setup Daniel Mack
2018-05-29 1:31 ` Kuninori Morimoto
2018-05-29 11:35 ` Mark Brown
2018-05-29 20:29 ` Daniel Mack
2018-05-30 9:10 ` Mark Brown
2018-05-30 9:12 ` Daniel Mack
2018-06-23 18:41 ` Daniel Mack
2018-06-25 11:24 ` Mark Brown
2018-06-25 12:55 ` Daniel Mack
2018-06-25 12:57 ` Mark Brown
2018-06-25 12:57 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529113243.GD23509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).