From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org, robh@kernel.org
Cc: devicetree@vger.kernel.org, bingbu.cao@linux.intel.com,
tian.shu.qiu@linux.intel.com, rajmohan.mani@intel.com
Subject: [PATCH 1/1] dw9807: Use the dongwoon,dw9807-vcm compatible string
Date: Tue, 29 May 2018 15:25:54 +0300 [thread overview]
Message-ID: <20180529122554.3325-1-sakari.ailus@linux.intel.com> (raw)
The original dw9807 DT bindings patch proposed the dongwoon,dw9807
compatible string. However, the device also includes an EEPROM on a
different I²C address. Indicate that this is just the VCM part of the
entire device.
The EEPROM part is compatible with the at24c64 for read-only access, with
1 kiB page size.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Hi Rob, others,
The original bindings were missing the EEPROM bit. This change recognises
it's there, and allows adding more elaborate support for it later on if
needed.
If this change is fine, I'll squash it to the original patches that are
not yet merged:
<URL:https://patchwork.linuxtv.org/patch/49613/>
<URL:https://patchwork.linuxtv.org/patch/49614/>
Thanks.
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 2 +-
drivers/media/i2c/dw9807.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
index 0a1a860beaff..c4701f1eaaf6 100644
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
@@ -5,5 +5,5 @@ controlling voice coil lenses.
Mandatory properties:
-- compatible: "dongwoon,dw9807"
+- compatible: "dongwoon,dw9807-vcm"
- reg: I2C slave address
diff --git a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c
index 6ebb98717fb1..8ba3920b6e2f 100644
--- a/drivers/media/i2c/dw9807.c
+++ b/drivers/media/i2c/dw9807.c
@@ -302,7 +302,7 @@ static int __maybe_unused dw9807_vcm_resume(struct device *dev)
}
static const struct of_device_id dw9807_of_table[] = {
- { .compatible = "dongwoon,dw9807" },
+ { .compatible = "dongwoon,dw9807-vcm" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, dw9807_of_table);
--
2.11.0
next reply other threads:[~2018-05-29 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 12:25 Sakari Ailus [this message]
2018-05-31 17:27 ` [PATCH 1/1] dw9807: Use the dongwoon,dw9807-vcm compatible string Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529122554.3325-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=robh@kernel.org \
--cc=tian.shu.qiu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).