From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Date: Wed, 30 May 2018 08:07:57 -0700 Message-ID: <20180530150757.GF5705@atomide.com> References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-7-faiz_abbas@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180530141133.3711-7-faiz_abbas@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Faiz Abbas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, paul@pwsan.com, t-kristo@ti.com List-Id: devicetree@vger.kernel.org * Faiz Abbas [180530 14:12]: > From: Franklin S Cooper Jr > > Add support for the MCAN peripheral which supports both classic > CAN messages along with the new CAN-FD message. ... > --- a/arch/arm/boot/dts/dra76x.dtsi > +++ b/arch/arm/boot/dts/dra76x.dtsi > @@ -27,6 +27,21 @@ > ti,syss-mask = <1>; > clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>; > clock-names = "fck"; > + > + m_can0: mcan@42c01a00 { > + compatible = "bosch,m_can"; > + reg = <0x1a00 0x4000>, <0x0 0x18FC>; > + reg-names = "m_can", "message_ram"; > + interrupt-parent = <&gic>; > + interrupts = , > + ; > + interrupt-names = "int0", "int1"; > + ti,hwmods = "mcan"; The "ti,hwmods" should be in the parent node now. But you may not even need it, see the reset comment I made for the parent node patch. > + clocks = <&mcan_clk>, <&l3_iclk_div>; > + clock-names = "cclk", "hclk"; > + bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>; > + status = "disabled"; And then you should be able to also leave out status = "disabled" as the hardware is there for sure and we can idle it. Then a board specific dts file can set it to "disabled" if reallly needed. Setting everything manually to "disabled" and then again to "enabled" is the wrong way around, the default is "enabled". Regards, Tony