From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 3/5] Documentation: DT: add i.MX EPIT timer binding Date: Wed, 30 May 2018 22:10:08 -0500 Message-ID: <20180531031008.GA30302@rob-hp-laptop> References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-4-peron.clem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180530120327.27681-4-peron.clem@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Colin Didier , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , Fabio Estevam , Vladimir Zapolskiy , Sascha Hauer , NXP Linux Team , Pengutronix Kernel Team , =?iso-8859-1?Q?Cl=E9ment?= Peron List-Id: devicetree@vger.kernel.org On Wed, May 30, 2018 at 02:03:25PM +0200, Clément Péron wrote: > From: Clément Peron "dt-bindings: timer: ..." is the preferred subject prefix. > > Add devicetree binding document for NXP's i.MX SoC specific > EPIT timer driver. > > Signed-off-by: Clément Peron > --- > .../devicetree/bindings/timer/fsl,imxepit.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxepit.txt > > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxepit.txt b/Documentation/devicetree/bindings/timer/fsl,imxepit.txt > new file mode 100644 > index 000000000000..90112d58af10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/fsl,imxepit.txt > @@ -0,0 +1,24 @@ > +Binding for the i.MX EPIT timer > + > +This binding uses the common clock binding[1]. > + > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt No need to state this. Listing "clocks" tells us that. > + > +Required properties: > +- compatible: should be "fsl,imx31-epit" What about imx6q listed below? > +- reg: physical base address of the controller and length of memory mapped > + region. > +- interrupts: Should contain EPIT controller interrupt > +- clocks: list of clock specifiers, must contain an entry for each required > + entry in clock-names > +- clock-names : should include entries "ipg", "per" > + > +Example for i.MX6QDL: > + epit1: epit@20d0000 { timer@... > + compatible = "fsl,imx6q-epit", "fsl,imx31-epit"; > + reg = <0x020d0000 0x4000>; > + interrupts = <0 56 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6QDL_CLK_IPG_PER>, > + <&clks IMX6QDL_CLK_EPIT1>; > + clock-names = "ipg", "per"; > + }; > -- > 2.17.0 >