Re: [PATCH v3 8/8] ARM: dts: rcar-gen2: Remove unused VIN properties

Simon Horman
2018-06-05T07:49:38Z

On Mon, Jun 04, 2018 at 02:23:25PM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your work.
>
> On 2018-05-29 17:05:59 +0200, Jacopo Mondi wrote:
> > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN
> > driver and only confuse users. Remove them in all Gen2 SoC that use
> > them.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> The more I think about this the more I lean towards that this patch
> should be dropped. The properties accurately describes the hardware and
> I think there is value in that. That the driver currently don't parse or
> make use of them don't in my view reduce there value. Maybe you should
> break out this patch to a separate series?

I also think there is value in describing the hardware not the state of the
driver at this time. Is there any missmatch between these properties and
the bindings?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org