Re: [PATCH v2 3/4] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC

[Rob Herring <robh@kernel.org>]

On Fri, May 25, 2018 at 04:17:15PM -0400, Liming Sun wrote:

Commit msg?

> Reviewed-by: David Woods <dwoods@mellanox.com>
> Signed-off-by: Liming Sun <lsun@mellanox.com>
> ---
>  .../devicetree/bindings/soc/mellanox/tmfifo.txt      | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt
> 
> diff --git a/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt
> new file mode 100644
> index 0000000..0a362f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mellanox/tmfifo.txt
> @@ -0,0 +1,20 @@
> +* Mellanox BlueField SoC TmFifo
> +
> +BlueField TmFifo provides a shared FIFO between the target and the
> +external host machine, which can be accessed via USB or PCIe.

A FIFO for what? I'd like to find a better spot than bindings/soc/
> +
> +Required properties:
> +
> +- compatible:	Should be "mellanox,bf-tmfifo"
> +- reg:		Physical base address and length of Rx/Tx block
> +- interrupts:	The interrupt number of Rx low water mark, Rx high water mark
> +		Tx low water mark, Tx high water mark respectively.
> +
> +Example:
> +
> +tmfifo@800a20 {
> +	compatible = "mellanox,bf-tmfifo";
> +	reg = <0x00800a20 0x00000018
> +	       0x00800a40 0x00000018>;
> +	interrupts = <41, 42, 43, 44>;
> +};
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html