From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/6] mtd: rawnand: tegra: add devicetree binding Date: Wed, 30 May 2018 22:45:23 -0500 Message-ID: <20180531034523.GA5417@rob-hp-laptop> References: <20180527215442.14760-3-stefan@agner.ch> <20180528002354.45025afd@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180528002354.45025afd@xps13> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Stefan Agner , boris.brezillon@bootlin.com, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, mark.rutland@arm.com, thierry.reding@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, dev@lynxeye.de, richard@nod.at, marcel@ziswiler.com, krzk@kernel.org, digetx@gmail.com, benjamin.lindqvist@endian.se, jonathanh@nvidia.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mirza.krak@gmail.com, linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org List-Id: devicetree@vger.kernel.org On Mon, May 28, 2018 at 12:23:54AM +0200, Miquel Raynal wrote: > Hi Stefan, > > On Sun, 27 May 2018 23:54:38 +0200, Stefan Agner > wrote: > > > From: Lucas Stach > > > > This adds the devicetree binding for the Tegra 2 NAND flash > > controller. > > > > Signed-off-by: Lucas Stach > > Signed-off-by: Stefan Agner > > --- > > .../bindings/mtd/nvidia,tegra20-nand.txt | 62 +++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt > > new file mode 100644 > > index 000000000000..49e472af1b39 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/nvidia,tegra20-nand.txt > > @@ -0,0 +1,62 @@ > > +NVIDIA Tegra NAND Flash controller > > + > > +Required properties: > > +- compatible: Must be one of: > > Nitpick: just put the compatible here as there is only one? No, this is how I ask people to format it. Rob