public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: avifishman70@gmail.com
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
	tmaimon77@gmail.com, venture@google.com, yuenn@google.com,
	brendanhiggins@google.com, mathias.nyman@linux.intel.com,
	bjorn.andersson@linaro.org, jhogan@kernel.org, albeu@free.fr,
	chunfeng.yun@mediatek.com, tony@atomide.com,
	baolu.lu@linux.intel.com, elder@linaro.org, digetx@gmail.com,
	kstewart@linuxfoundation.org, hdegoede@redhat.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	openbmc@lists.ozlabs.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, davem@davemloft.net,
	mchehab+samsung@kernel.org, akpm@linux-foundation.org,
	rdunlap@infradead.org
Subject: Re: [PATCH v1 2/3] USB: DT probing support to ehci-npcm7xx
Date: Wed, 30 May 2018 23:14:30 -0500	[thread overview]
Message-ID: <20180531041430.GA2862@rob-hp-laptop> (raw)
In-Reply-To: <1527582935-31175-3-git-send-email-avifishman70@gmail.com>

On Tue, May 29, 2018 at 11:35:34AM +0300, avifishman70@gmail.com wrote:
> From: Avi Fishman <AviFishman70@gmail.com>
> 
> Device Tree documentation for Nuvoton npcm7xx EHCI driver.

Bindings are for drivers, but for h/w.

> 
> Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
> ---
>  Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> new file mode 100644
> index 000000000000..628692dff7e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> @@ -0,0 +1,18 @@
> +Nuvoton NPCM7XX SoC USB controllers:
> +-----------------------------
> +
> +EHCI:
> +-----
> +
> +Required properties:
> +- compatible: "nuvoton,npcm750-ehci"

And usb-ehci? Though I would just drop it. It is pretty useless.

> +  that services interrupts for this device

This line goes below.

> +- interrupts: Should contain the EHCI interrupt
> +
> +Example:
> +
> +	ehci@e1800000 {
> +		compatible = "nuvoton,npcm750-ehci", "usb-ehci";
> +		reg = <0xf0806000 0x1000>;
> +		interrupts = <0 61 4>;
> +	};
> -- 
> 2.14.1
> 

  reply	other threads:[~2018-05-31  4:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  8:35 [PATCH v1 0/3] USB host: Add USB ehci support for nuvoton npcm7xx avifishman70
2018-05-29  8:35 ` [PATCH v1 1/3] USB host: Add USB ehci support for nuvoton npcm7xx platform avifishman70
2018-05-29  8:35 ` [PATCH v1 2/3] USB: DT probing support to ehci-npcm7xx avifishman70
2018-05-31  4:14   ` Rob Herring [this message]
2018-05-29  8:35 ` [PATCH v1 3/3] MAINTAINERS: add subfolders for nuvoton *npcm* avifishman70
2018-05-30 16:01 ` [PATCH v1 0/3] USB host: Add USB ehci support for nuvoton npcm7xx Avi Fishman
2018-05-30 16:22   ` Avi Fishman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531041430.GA2862@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=albeu@free.fr \
    --cc=avifishman70@gmail.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=brendanhiggins@google.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=elder@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jhogan@kernel.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rdunlap@infradead.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tmaimon77@gmail.com \
    --cc=tony@atomide.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox