From: Guenter Roeck <linux@roeck-us.net>
To: Brian Norris <briannorris@chromium.org>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Rhyland Klein <rklein@nvidia.com>,
Alexandru Stan <amstan@chromium.org>,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"
Date: Fri, 1 Jun 2018 10:35:00 -0700 [thread overview]
Message-ID: <20180601173500.GB22509@roeck-us.net> (raw)
In-Reply-To: <20180601172400.50737-2-briannorris@chromium.org>
On Fri, Jun 01, 2018 at 10:24:00AM -0700, Brian Norris wrote:
> This compatible property was documented before the driver was renamed to
> "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate
> bq20z75->sbs rename to dt bindings")). The driver has continued to
> support this property as an alternative to "sbs,sbs-battery", and
> because we've noticed there are some lingering TI specifics (in the
> manufacturer-specific portion of the SBS spec), we'd like to start using
> this property again to differentiate.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Acked-by: Rhyland Klein <rklein@nvidia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: add Rhyland's Acked-by
> ---
> .../devicetree/bindings/power/supply/sbs_sbs-battery.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> index c40e8926facf..a7a9c3366f82 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> @@ -2,7 +2,7 @@ SBS sbs-battery
> ~~~~~~~~~~
>
> Required properties :
> - - compatible : "sbs,sbs-battery"
> + - compatible : "sbs,sbs-battery" or "ti,bq20z75"
>
> Optional properties :
> - sbs,i2c-retry-count : The number of times to retry i2c transactions on i2c
> --
> 2.17.0.921.gf22659ad46-goog
>
next prev parent reply other threads:[~2018-06-01 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 17:23 [PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats Brian Norris
2018-06-01 17:24 ` [PATCH v2 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75" Brian Norris
2018-06-01 17:35 ` Guenter Roeck [this message]
2018-06-01 17:34 ` [PATCH v2 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats Guenter Roeck
2018-06-01 18:31 ` Brian Norris
2018-06-01 22:08 ` Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601173500.GB22509@roeck-us.net \
--to=linux@roeck-us.net \
--cc=amstan@chromium.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox